From: Stefan Hajnoczi <stefanha@gmail.com>
To: Andrey Korolyov <andrey@xdel.ru>
Cc: qemu-stabled@nongnu.org, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] 2.1 unexpected stop after exporting blockdev via nbd server
Date: Tue, 6 Jan 2015 11:43:19 +0000 [thread overview]
Message-ID: <20150106114319.GC29775@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <CABYiri_NuTJJeuRizM-s0X-dGU_ENH=QJpmr8-d7td4OQaeJZg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1775 bytes --]
On Mon, Jan 05, 2015 at 05:12:10PM +0400, Andrey Korolyov wrote:
> On Fri, Jan 2, 2015 at 4:04 PM, Stefan Hajnoczi <stefanha@gmail.com> wrote:
> > On Thu, Dec 18, 2014 at 07:38:59PM +0400, Andrey Korolyov wrote:
> >> 2.1-stable is currently crashing with the
> >>
> >> Co-routine re-entered recursively
> >> 2014-12-16 15:06:23.578+0000: shutting down
> >>
> >> after execution of (for example) following when using virtio-dp as a
> >> disk backend:
> >>
> >> '{ "execute": "nbd-server-start", "arguments": { "addr": { "type":
> >> "inet", "data": { "host": "10.6.0.1", "port": "3333" } } } }'
> >> '{ "execute": "nbd-server-add", "arguments": {"device":
> >> "drive-virtio-disk0","writable": false } }'
> >
> > Hi,
> > You need patches from Max Reitz that make the run-time NBD server
> > support dataplane:
> > f214928 nbd: Follow the BDS' AIO context
> > 3338442 block: Add AIO context notifiers
> > 958c717 nbd: Drop nbd_can_read()
> >
> > Please try QEMU v2.2.0 or qemu.git.
> >
> > Stefan
>
> Thanks Stefan, those commits are enough to make dataplane drive work
> well with runtime nbd server. By the way, can such functionality
> improvements (not major improvements like discard support for scsi)
> make their way as backports? To reword this, unexpected behavior like
> sudden shutdown I described is better to be closed by later fixes than
> by stubs or left as it currently behaving IMO.
It is a bug that NBD combined with virtio-blk dataplane aborted, it
should have produced an error message and simply refused to start the
NBD server.
Now that QEMU 2.2 stable has been released I'm not sure if additional
2.1.x releases will be made at all. I have CCed qemu-stabled@nongnu.org
to see if there is interest.
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-01-06 11:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-18 15:38 [Qemu-devel] 2.1 unexpected stop after exporting blockdev via nbd server Andrey Korolyov
2015-01-02 13:04 ` Stefan Hajnoczi
2015-01-05 13:12 ` Andrey Korolyov
2015-01-06 11:43 ` Stefan Hajnoczi [this message]
2015-01-06 11:49 ` Stefan Hajnoczi
2015-01-08 1:17 ` [Qemu-devel] [Qemu-stable] " Michael Roth
2015-01-08 10:31 ` Stefan Hajnoczi
2015-01-08 12:11 ` Paolo Bonzini
2015-01-08 13:25 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150106114319.GC29775@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=andrey@xdel.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stabled@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).