From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59706) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y8SdS-0007aN-QE for qemu-devel@nongnu.org; Tue, 06 Jan 2015 06:49:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y8SdP-0003lb-Je for qemu-devel@nongnu.org; Tue, 06 Jan 2015 06:49:18 -0500 Date: Tue, 6 Jan 2015 11:49:11 +0000 From: Stefan Hajnoczi Message-ID: <20150106114911.GE29775@stefanha-thinkpad.redhat.com> References: <20150102130439.GH10823@stefanha-thinkpad.redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="+JUInw4efm7IfTNU" Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] 2.1 unexpected stop after exporting blockdev via nbd server List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andrey Korolyov Cc: "qemu-devel@nongnu.org" , qemu-stable@nongnu.org --+JUInw4efm7IfTNU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 05, 2015 at 05:12:10PM +0400, Andrey Korolyov wrote: > On Fri, Jan 2, 2015 at 4:04 PM, Stefan Hajnoczi wrot= e: > > On Thu, Dec 18, 2014 at 07:38:59PM +0400, Andrey Korolyov wrote: > >> 2.1-stable is currently crashing with the > >> > >> Co-routine re-entered recursively > >> 2014-12-16 15:06:23.578+0000: shutting down > >> > >> after execution of (for example) following when using virtio-dp as a > >> disk backend: > >> > >> '{ "execute": "nbd-server-start", "arguments": { "addr": { "type": > >> "inet", "data": { "host": "10.6.0.1", "port": "3333" } } } }' > >> '{ "execute": "nbd-server-add", "arguments": {"device": > >> "drive-virtio-disk0","writable": false } }' > > > > Hi, > > You need patches from Max Reitz that make the run-time NBD server > > support dataplane: > > f214928 nbd: Follow the BDS' AIO context > > 3338442 block: Add AIO context notifiers > > 958c717 nbd: Drop nbd_can_read() > > > > Please try QEMU v2.2.0 or qemu.git. > > > > Stefan >=20 > Thanks Stefan, those commits are enough to make dataplane drive work > well with runtime nbd server. By the way, can such functionality > improvements (not major improvements like discard support for scsi) > make their way as backports? To reword this, unexpected behavior like > sudden shutdown I described is better to be closed by later fixes than > by stubs or left as it currently behaving IMO. Oops, I typoed the qemu-stable@nongnu.org email address. Trying again... QEMU stable folks: will there be another 2.1.x release? Stefan --+JUInw4efm7IfTNU Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUq8u3AAoJEJykq7OBq3PIWrMH/A7xMRbLo4RJguibtEcwjYHF Hl7qzndkqd3db6m8LUhhV9uT1yOOf9S0sJbrdf9gZcLfWR1ZHF1VUqckbN9XkWU+ Q2cj94M0rXRgl/PbRfsgskXbL6dV0fp7Y412t/RulIB3d7naxQ6kH4QtSN84is60 0OSX/Hc5pVMkTzcHPCpX3d6zsKHOd5ISW9DI+OQdyRDawdZA9wnZFazERyT0VB1N fPEPZ2Jd4WXF2MxxzN4mINvUqTfEgPmCi8KYvHTNG1YDYjYbye8lFcXr/Vyz+wS+ aBXtyGvbHZfBiC+3cLwStIU5G9K+7OWjpbeQkh3Si67XJkhAPFU1/okIy625ru4= =HgYU -----END PGP SIGNATURE----- --+JUInw4efm7IfTNU--