From: Stefan Hajnoczi <stefanha@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH] net: remove all cleanup methods from NIC NetClientInfos
Date: Tue, 6 Jan 2015 12:58:14 +0000 [thread overview]
Message-ID: <20150106125814.GG29775@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <54A6C5C3.60704@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 536 bytes --]
On Fri, Jan 02, 2015 at 05:22:27PM +0100, Paolo Bonzini wrote:
>
>
> On 02/01/2015 15:00, Stefan Hajnoczi wrote:
> >>> This cleanup function gets in the way of making the
> >>> NetClientStates for the NIC hold an object_ref reference to
> >>> the object, so get rid of it.
> > This patch does not drop NetClientInfo->cleanup() and clean up
> > net.c. Do you have plans for a follow-up patch?
>
> No, it is still in use by backends in net/. Only NICs do not need it.
Good point, not sure how I missed that.
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-01-06 12:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-23 16:53 [Qemu-devel] [PATCH] net: remove all cleanup methods from NIC NetClientInfos Paolo Bonzini
2015-01-02 14:00 ` Stefan Hajnoczi
2015-01-02 16:22 ` Paolo Bonzini
2015-01-06 12:58 ` Stefan Hajnoczi [this message]
2015-01-06 12:59 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150106125814.GG29775@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).