From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41276) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y8TiI-0001E6-1e for qemu-devel@nongnu.org; Tue, 06 Jan 2015 07:58:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y8TiE-0000Gy-M4 for qemu-devel@nongnu.org; Tue, 06 Jan 2015 07:58:21 -0500 Received: from mail-wg0-x235.google.com ([2a00:1450:400c:c00::235]:41691) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y8TiE-0000Gt-F2 for qemu-devel@nongnu.org; Tue, 06 Jan 2015 07:58:18 -0500 Received: by mail-wg0-f53.google.com with SMTP id x13so11313437wgg.26 for ; Tue, 06 Jan 2015 04:58:17 -0800 (PST) Date: Tue, 6 Jan 2015 12:58:14 +0000 From: Stefan Hajnoczi Message-ID: <20150106125814.GG29775@stefanha-thinkpad.redhat.com> References: <1419353600-30519-1-git-send-email-pbonzini@redhat.com> <20150102140052.GK10823@stefanha-thinkpad.redhat.com> <54A6C5C3.60704@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Cp3Cp8fzgozWLBWL" Content-Disposition: inline In-Reply-To: <54A6C5C3.60704@redhat.com> Subject: Re: [Qemu-devel] [PATCH] net: remove all cleanup methods from NIC NetClientInfos List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, stefanha@redhat.com --Cp3Cp8fzgozWLBWL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 02, 2015 at 05:22:27PM +0100, Paolo Bonzini wrote: >=20 >=20 > On 02/01/2015 15:00, Stefan Hajnoczi wrote: > >>> This cleanup function gets in the way of making the=20 > >>> NetClientStates for the NIC hold an object_ref reference to > >>> the object, so get rid of it. > > This patch does not drop NetClientInfo->cleanup() and clean up=20 > > net.c. Do you have plans for a follow-up patch? >=20 > No, it is still in use by backends in net/. Only NICs do not need it. Good point, not sure how I missed that. Stefan --Cp3Cp8fzgozWLBWL Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUq9vmAAoJEJykq7OBq3PI6L0H/RMk/S7rM1UMsEJCbXc87bZF kqEWreE1iCttUkc8tnxL1opVoRB6IRLicTkE2/MA+j6fAnRUSp+hXfJf8oyeGieK Ll9TQFkW/TWLRmuLMxB7RLRTZ5Ye9nAWr7XPmOk2q+mhmfkOLLvGru/fVI4R7KJu f2prIkC/9NrQM/IS8SC1codUv8kpOkaR6lk6My9cDi9zUwpwmBUdF03UDQyuizOc kM6nhGb7cukuLfgm6yDd94wOBk5q1WrIOl3NNYoPepD2cYAYu+nKX6OVNXIugipo SuuRkWReCZjA3Hkm38u+LrAi23oNtxlHt1Mwfme9EpG13UvSYxO2Ul96slPHhiY= =SmnF -----END PGP SIGNATURE----- --Cp3Cp8fzgozWLBWL--