From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49420) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y8UPK-0004bd-NE for qemu-devel@nongnu.org; Tue, 06 Jan 2015 08:42:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y8UPH-0006dv-FF for qemu-devel@nongnu.org; Tue, 06 Jan 2015 08:42:50 -0500 Received: from mail-wi0-x22b.google.com ([2a00:1450:400c:c05::22b]:36809) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y8UPH-0006dm-7H for qemu-devel@nongnu.org; Tue, 06 Jan 2015 08:42:47 -0500 Received: by mail-wi0-f171.google.com with SMTP id bs8so5366777wib.4 for ; Tue, 06 Jan 2015 05:42:46 -0800 (PST) Date: Tue, 6 Jan 2015 13:42:41 +0000 From: Stefan Hajnoczi Message-ID: <20150106134241.GJ29775@stefanha-thinkpad.redhat.com> References: <1419692504-29373-1-git-send-email-peter@lekensteyn.nl> <1419692504-29373-3-git-send-email-peter@lekensteyn.nl> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="pWOmaDnDlrCGjNh4" Content-Disposition: inline In-Reply-To: <1419692504-29373-3-git-send-email-peter@lekensteyn.nl> Subject: Re: [Qemu-devel] [PATCH 02/10] block/dmg: extract mish block decoding functionality List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Wu Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi --pWOmaDnDlrCGjNh4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Dec 27, 2014 at 04:01:36PM +0100, Peter Wu wrote: > Extract the mish block decoder such that this can be used for other > formats in the future. A new DmgHeaderState struct is introduced to > share state while decoding. >=20 > The code is kept unchanged as much as possible, a "fail" label is added > for example where a simple return would probably do. >=20 > Signed-off-by: Peter Wu > --- > block/dmg.c | 216 +++++++++++++++++++++++++++++++++++-------------------= ------ > 1 file changed, 125 insertions(+), 91 deletions(-) Reviewed-by: Stefan Hajnoczi --pWOmaDnDlrCGjNh4 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUq+ZRAAoJEJykq7OBq3PIbAAIAIZwzEuoQ9sLm5vwFUqHl+Mt K5syLHVnhFtrYA/yxrxpvetQcCYfyTRnTwsgHg8mN1ZkoyMYjlv2LBUBgGR1mjmc l1SHqlQqydTsjnTaBnXtuXj5vZqckw+URonGaQYTViGVdL3hn182oFf6dqM1eiJ6 GdAFn2w6tFdkoNKXlR97YYDKF+V8IsPl2Kkcjj2OsS1+z7zyRSJnh+b6GTP58jED 76T5wubfrYBG6TB33WJno2i4m0M5sJyAkja1xiaPp+S++zsk1iVC36IJzrvpQJlk f3944mLmuFu85z/v2wSJvmOxrysdMcv4UWf6aTmkrgcvxsbI/d4l2R+JLtHkPog= =tWzq -----END PGP SIGNATURE----- --pWOmaDnDlrCGjNh4--