From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44091) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y8VoD-0003vD-Dp for qemu-devel@nongnu.org; Tue, 06 Jan 2015 10:12:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y8Vo5-0007ub-Kk for qemu-devel@nongnu.org; Tue, 06 Jan 2015 10:12:37 -0500 Received: from mail-we0-x232.google.com ([2a00:1450:400c:c03::232]:41960) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y8Vo5-0007uS-EK for qemu-devel@nongnu.org; Tue, 06 Jan 2015 10:12:29 -0500 Received: by mail-we0-f178.google.com with SMTP id p10so9788715wes.23 for ; Tue, 06 Jan 2015 07:12:28 -0800 (PST) Date: Tue, 6 Jan 2015 15:12:20 +0000 From: Stefan Hajnoczi Message-ID: <20150106151220.GO29775@stefanha-thinkpad.redhat.com> References: <1420511101-8352-1-git-send-email-sfeldma@gmail.com> <1420511101-8352-9-git-send-email-sfeldma@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="0u4QAjBqqw4+MLTw" Content-Disposition: inline In-Reply-To: <1420511101-8352-9-git-send-email-sfeldma@gmail.com> Subject: Re: [Qemu-devel] [PATCH v2 07/10] rocker: add new rocker switch device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: sfeldma@gmail.com Cc: john.fastabend@gmail.com, roopa@cumulusnetworks.com, jiri@resnulli.us, qemu-devel@nongnu.org --0u4QAjBqqw4+MLTw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 05, 2015 at 06:24:58PM -0800, sfeldma@gmail.com wrote: > From: Scott Feldman >=20 > Rocker is a simulated ethernet switch device. The device supports up to = 62 > front-panel ports and supports L2 switching and L3 routing functions, as = well > as L2/L3/L4 ACLs. The device presents a single PCI device for each switc= h, > with a memory-mapped register space for device driver access. >=20 > Rocker device is invoked with -device, for example a 4-port switch: >=20 > -device rocker,name=3Dsw1,len-ports=3D4,ports[0]=3Ddev0,ports[1]=3Ddev1= , \ > ports[2]=3Ddev2,ports[3]=3Ddev3 >=20 > Each port is a netdev and can be paired with using -netdev id=3D. This design looks good, it fits the QEMU network subsystem. Please follow QEMU coding style, for example, using typedefs for structs instead of "struct tag". Details are in ./HACKING, ./CODING_STYLE, and you can scan patches with QEMU's scripts/checkpatch.pl. --0u4QAjBqqw4+MLTw Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUq/tUAAoJEJykq7OBq3PIDC4IAMntxy1EASW0tZEoLJu1sEDH Azy1DtnvYESmZe2IprWkRYlcDatlZTDXt0fPZogUKjFZZfd0A05laFnHJs2SjOJp CztcPkXPwQsbmUEiPu7hXbO3qmWZ3IAND+hrlHp1eWua8FZF3KySr4cN9LoMPRWg P10oDr8a7vDZE4OOFqz8Tjwbrgpj129Tf5/tHkEL2z3Pcln+WxmAu0bbqIN/1Wbr R0j63fdF9Re5BDEBdciXMn9cRnmeKEnVvofTx53MwXsdD2AaN/pHbcF5pYhYSKCm bDoFJtEGBLANeyw7Ac/jtM8nOEIoO0Sftb5to0M/XGlINOisxXf7gnL2SC50ufo= =zGFL -----END PGP SIGNATURE----- --0u4QAjBqqw4+MLTw--