Re: [Qemu-devel] [PATCH v2 08/10] qmp: add rocker device support

[Stefan Hajnoczi <stefanha@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1369 bytes --]

On Mon, Jan 05, 2015 at 06:24:59PM -0800, sfeldma@gmail.com wrote:
> From: Scott Feldman <sfeldma@gmail.com>
> 
> Add QMP/HMP support for rocker devices.  This is mostly for debugging purposes
> to see inside the device's tables and port configurations.  Some examples:
> 
> (qemu) rocker sw1
> name: sw1
> id: 0x0000013512005452
> ports: 4

The convention is for HMP commands that show information to be "info"
sub-commands.  So this example would be "info rocker sw1".  See
monitor.c:info_cmds[].

The convention for QMP is to call the command "query-rocker".

> 
> (qemu) rocker-ports sw1
>             ena/    speed/ auto
>       port  link    duplex neg?
>      sw1.1  up     10G  FD  No
>      sw1.2  up     10G  FD  No
>      sw1.3  !ena   10G  FD  No
>      sw1.4  !ena   10G  FD  No

HMP: info rocker-ports sw1
QMP: query-rocker-ports

and so on.

> +##
> +# @RockerOfDpaFlow:
> +#
> +# Rocker switch OF-DPA flow
> +#
> +# @cookie: flow unique cookie ID
> +#
> +# @hits: count of matches (hits) on flow
> +#
> +# @key: flow key
> +#
> +# @mask: flow mask
> +#
> +# @action: flow action
> +##

For versioning, the schema should mention which QEMU release a command
was added in:

 # Since: 2.3

That way QAPI consumers can plan accordingly and be aware when older
QEMU binaries may not implement a command.

[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]