qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: William Dauchy <william@gandi.net>
To: Marcel Apfelbaum <marcel@redhat.com>
Cc: pbonzini@redhat.com, qemu-stable@nongnu.org,
	qemu-devel@nongnu.org, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3] vl.c: fix regression when reading machine type from config file
Date: Wed, 7 Jan 2015 14:23:01 +0100	[thread overview]
Message-ID: <20150107132301.GE5089@gandi.net> (raw)
In-Reply-To: <1420632698-27461-1-git-send-email-marcel@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 920 bytes --]

On Jan07 14:11, Marcel Apfelbaum wrote:
> After 'Machine as QOM' series the machine type input triggers
> the creation of the machine class.
> If the machine type is set in the configuration file, the machine
> class is not updated accordingly and remains the default.

I have also tested it; it does work.

Thanks,

> Fixed that by querying the machine options after the configuration
> file is loaded.
> 
> Cc: qemu-stable@nongnu.org
> Reported-by: William Dauchy <william@gandi.net>
> Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
> ---
> v2 -> v3:
>  - Addressed Paolo Bonzini's comments:
>    - fixed whitespace
> v1 -> v2:
>  - Addressed Paolo Bonzini's comments:
>    - moved the call to machine_parse after the switch
>      and brought QEMU_OPTION_M near QEMU_OPTION_machine
>   
>  vl.c | 15 ++++++++-------
>  1 file changed, 8 insertions(+), 7 deletions(-)
> 
-- 
William

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

      parent reply	other threads:[~2015-01-07 13:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-07 12:11 [Qemu-devel] [PATCH v3] vl.c: fix regression when reading machine type from config file Marcel Apfelbaum
2015-01-07 12:12 ` Paolo Bonzini
2015-01-07 15:37   ` Marcel Apfelbaum
2015-01-07 15:44     ` Paolo Bonzini
2015-01-07 13:23 ` William Dauchy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150107132301.GE5089@gandi.net \
    --to=william@gandi.net \
    --cc=armbru@redhat.com \
    --cc=marcel@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).