From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44762)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <william@gandi.net>) id 1Y8qiG-0007O6-NQ
	for qemu-devel@nongnu.org; Wed, 07 Jan 2015 08:31:54 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <william@gandi.net>) id 1Y8qiD-0000xd-0x
	for qemu-devel@nongnu.org; Wed, 07 Jan 2015 08:31:52 -0500
Date: Wed, 7 Jan 2015 14:23:01 +0100
From: William Dauchy <william@gandi.net>
Message-ID: <20150107132301.GE5089@gandi.net>
References: <1420632698-27461-1-git-send-email-marcel@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="+SfteS7bOf3dGlBC"
Content-Disposition: inline
In-Reply-To: <1420632698-27461-1-git-send-email-marcel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3] vl.c: fix regression when reading
 machine type from config file
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Marcel Apfelbaum <marcel@redhat.com>
Cc: pbonzini@redhat.com, qemu-stable@nongnu.org, qemu-devel@nongnu.org, armbru@redhat.com


--+SfteS7bOf3dGlBC
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Jan07 14:11, Marcel Apfelbaum wrote:
> After 'Machine as QOM' series the machine type input triggers
> the creation of the machine class.
> If the machine type is set in the configuration file, the machine
> class is not updated accordingly and remains the default.

I have also tested it; it does work.

Thanks,

> Fixed that by querying the machine options after the configuration
> file is loaded.
>=20
> Cc: qemu-stable@nongnu.org
> Reported-by: William Dauchy <william@gandi.net>
> Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
> ---
> v2 -> v3:
>  - Addressed Paolo Bonzini's comments:
>    - fixed whitespace
> v1 -> v2:
>  - Addressed Paolo Bonzini's comments:
>    - moved the call to machine_parse after the switch
>      and brought QEMU_OPTION_M near QEMU_OPTION_machine
>  =20
>  vl.c | 15 ++++++++-------
>  1 file changed, 8 insertions(+), 7 deletions(-)
>=20
--=20
William

--+SfteS7bOf3dGlBC
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAlStMzUACgkQ1I6eqOUidQG1OQCgtL3iQ6pxVxt3UuorJYNYBJQO
ZNoAoK37uBc4vOxjsYUYWlGWUjZkPhzU
=4Uyg
-----END PGP SIGNATURE-----

--+SfteS7bOf3dGlBC--