Re: [Qemu-devel] [PATCH] block: Split BLOCK_OP_TYPE_COMMIT to BLOCK_OP_TYPE_COMMIT_{SOURCE, TARGET}

[Stefan Hajnoczi <stefanha@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1009 bytes --]

On Thu, Sep 11, 2014 at 01:14:00PM +0800, Fam Zheng wrote:
> Like BLOCK_OP_TYPE_BACKUP_SOURCE and BLOCK_OP_TYPE_BACKUP_TARGET,
> block-commit involves two asymmetric devices.
> 
> This change is not user-visible (yet), because commit only works with
> device names.
> 
> But once we enable backing reference in blockdev-add, or specifying
> node-name in block-commit command, we don't want the user to start two
> commit jobs on the same backing chain, which will corrupt things because
> of the final bdrv_swap.
> 
> Before we have per category blockers, splitting this type is still
> better.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  block.c               | 6 +++---
>  blockdev.c            | 6 +++++-
>  include/block/block.h | 3 ++-
>  3 files changed, 10 insertions(+), 5 deletions(-)

Sorry for missing this patch, it was not on my radar since it has no
Reveiwed-by.

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan

[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]