From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49849) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y8rMs-0002tO-4P for qemu-devel@nongnu.org; Wed, 07 Jan 2015 09:13:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y8rMn-0000bz-5N for qemu-devel@nongnu.org; Wed, 07 Jan 2015 09:13:50 -0500 Received: from mail-wg0-x231.google.com ([2a00:1450:400c:c00::231]:60442) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y8rMm-0000bi-UU for qemu-devel@nongnu.org; Wed, 07 Jan 2015 09:13:45 -0500 Received: by mail-wg0-f49.google.com with SMTP id n12so1243959wgh.8 for ; Wed, 07 Jan 2015 06:13:44 -0800 (PST) Date: Wed, 7 Jan 2015 14:13:38 +0000 From: Stefan Hajnoczi Message-ID: <20150107141338.GC22440@stefanha-thinkpad.redhat.com> References: <1410412440-2168-1-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="c3bfwLpm8qysLVxt" Content-Disposition: inline In-Reply-To: <1410412440-2168-1-git-send-email-famz@redhat.com> Subject: Re: [Qemu-devel] [PATCH] block: Split BLOCK_OP_TYPE_COMMIT to BLOCK_OP_TYPE_COMMIT_{SOURCE, TARGET} List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi , Benoit Canet --c3bfwLpm8qysLVxt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 11, 2014 at 01:14:00PM +0800, Fam Zheng wrote: > Like BLOCK_OP_TYPE_BACKUP_SOURCE and BLOCK_OP_TYPE_BACKUP_TARGET, > block-commit involves two asymmetric devices. >=20 > This change is not user-visible (yet), because commit only works with > device names. >=20 > But once we enable backing reference in blockdev-add, or specifying > node-name in block-commit command, we don't want the user to start two > commit jobs on the same backing chain, which will corrupt things because > of the final bdrv_swap. >=20 > Before we have per category blockers, splitting this type is still > better. >=20 > Signed-off-by: Fam Zheng > --- > block.c | 6 +++--- > blockdev.c | 6 +++++- > include/block/block.h | 3 ++- > 3 files changed, 10 insertions(+), 5 deletions(-) Sorry for missing this patch, it was not on my radar since it has no Reveiwed-by. Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan --c3bfwLpm8qysLVxt Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUrT8SAAoJEJykq7OBq3PIfvYIAK87LI1F5ncpLIXO4P3b7iyN pvkU7XCPi8hSHYNJX1U3rFw/BXV671NNMS7zhL7vg/xXhvEz4/jNQUUtX5By1ufi MMcdgUvC9WAsXqeO1IEUB7FhELukMP5pNaKDwVIeRwLfA4/dlzlP7TLIYEnC8/Lv NgapP/QZRxHsSdOAgPJlMdIWynLUBHmLKEcbjoVTPkIfmZ6EKMNe76hQ2XEuE1DI lgklyAaMvurJ1yhrJZkWlyop6MSya0KKJzaiGTEJBJzsr63joT6wFIB4zKJkTO// qzUB50KL4PT/YGLppsv7JEZAz01wHbCqZVvAXkdaz5jJhNFMgZ7QJu4JpHLbbao= =2HD3 -----END PGP SIGNATURE----- --c3bfwLpm8qysLVxt--