From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56342)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Y8t2y-0008VX-Cv
	for qemu-devel@nongnu.org; Wed, 07 Jan 2015 11:01:25 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Y8t2x-000474-3Q
	for qemu-devel@nongnu.org; Wed, 07 Jan 2015 11:01:24 -0500
Date: Wed, 7 Jan 2015 16:01:19 +0000
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20150107160119.GN22440@stefanha-thinkpad.redhat.com>
References: <54909B80.4030602@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="4Y142/9l9nQlBiaj"
Content-Disposition: inline
In-Reply-To: <54909B80.4030602@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] hw/net/xen_nic.c: Need free 'netdev->nic'
 in net_free() instead of net_disconnect()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Chen Gang <gang.chen.5i5j@gmail.com>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>, qemu-devel <qemu-devel@nongnu.org>


--4Y142/9l9nQlBiaj
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Dec 17, 2014 at 04:52:16AM +0800, Chen Gang wrote:
> net_init() and net_free() are pairs, net_connect() and net_disconnect()
> are pairs. net_init() creates 'netdev->nic', so also need free it in
> net_free().
>=20
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
>  hw/net/xen_nic.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Thanks, applied to my net tree:
https://github.com/stefanha/qemu/commits/net

Stefan

--4Y142/9l9nQlBiaj
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJUrVhPAAoJEJykq7OBq3PIJu0H+wQ0gxu04l7QCE/+ESxlun/v
kFNiB+HsQCHKXZO4lm3ju5HYvJRFk4XU7W6/x63/6J3j0jQWbvIh5QXOecOpwHce
yP5b+Z1Fs7duediGDSL3fy7eJUCJKXEns8XDg2DCOV+B/HBpztypD9E1/+SJEU7W
baiwt29H9HFjYOn/2mtvAEV45fopE5bhzxJ3KT3wPSZ0yBOC+Gg2b4gwVc1boYT6
UNRBlmmY6gcopNKfWIcbSF/malu88uxGLI+sDRXD9XA8ZBghYBKm+hiN2IYcOFVE
amkEaXNzwfg8Sy1w0szzFV00hUWz7Tw/wzw8Y9XiTpsSat/w9Uzi9mPcS3QDywM=
=WPkD
-----END PGP SIGNATURE-----

--4Y142/9l9nQlBiaj--