From: Amit Shah <amit.shah@redhat.com>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: cristian.klein@cs.umu.se, qemu-devel@nongnu.org, quintela@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/3] socket shutdown
Date: Fri, 9 Jan 2015 12:20:23 +0530 [thread overview]
Message-ID: <20150109065023.GI6122@grmbl.mre> (raw)
In-Reply-To: <1420715492-5109-2-git-send-email-dgilbert@redhat.com>
On (Thu) 08 Jan 2015 [11:11:30], Dr. David Alan Gilbert (git) wrote:
> static const QEMUFileOps socket_write_ops = {
> - .get_fd = socket_get_fd,
> + .get_fd = socket_get_fd,
> .writev_buffer = socket_writev_buffer,
> - .close = socket_close
> + .close = socket_close,
> + .shut_down = socket_shutdown
Just including commas, even for the last item, helps in reducing the
number of changed lines..
Amit
next prev parent reply other threads:[~2015-01-09 6:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-08 11:11 [Qemu-devel] [PATCH 0/3] Migration cancel with dead network Dr. David Alan Gilbert (git)
2015-01-08 11:11 ` [Qemu-devel] [PATCH 1/3] socket shutdown Dr. David Alan Gilbert (git)
2015-01-09 6:50 ` Amit Shah [this message]
2015-01-08 11:11 ` [Qemu-devel] [PATCH 2/3] Handle bi-directional communication for fd migration Dr. David Alan Gilbert (git)
2015-01-08 11:11 ` [Qemu-devel] [PATCH 3/3] migration_cancel: shutdown migration socket Dr. David Alan Gilbert (git)
2015-01-08 11:22 ` [Qemu-devel] [PATCH 0/3] Migration cancel with dead network Daniel P. Berrange
2015-01-08 11:29 ` Dr. David Alan Gilbert
2015-01-08 11:33 ` Daniel P. Berrange
2015-01-08 12:10 ` Paolo Bonzini
2015-01-09 6:50 ` Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150109065023.GI6122@grmbl.mre \
--to=amit.shah@redhat.com \
--cc=cristian.klein@cs.umu.se \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).