From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53514)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1Y9TP6-0003VQ-Gn
	for qemu-devel@nongnu.org; Fri, 09 Jan 2015 01:50:41 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1Y9TP3-0007rm-A3
	for qemu-devel@nongnu.org; Fri, 09 Jan 2015 01:50:40 -0500
Received: from mx1.redhat.com ([209.132.183.28]:52559)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1Y9TP2-0007qa-TO
	for qemu-devel@nongnu.org; Fri, 09 Jan 2015 01:50:37 -0500
Date: Fri, 9 Jan 2015 12:20:23 +0530
From: Amit Shah <amit.shah@redhat.com>
Message-ID: <20150109065023.GI6122@grmbl.mre>
References: <1420715492-5109-1-git-send-email-dgilbert@redhat.com>
	<1420715492-5109-2-git-send-email-dgilbert@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1420715492-5109-2-git-send-email-dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/3] socket shutdown
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: cristian.klein@cs.umu.se, qemu-devel@nongnu.org, quintela@redhat.com

On (Thu) 08 Jan 2015 [11:11:30], Dr. David Alan Gilbert (git) wrote:

>  static const QEMUFileOps socket_write_ops = {
> -    .get_fd =     socket_get_fd,
> +    .get_fd        = socket_get_fd,
>      .writev_buffer = socket_writev_buffer,
> -    .close =      socket_close
> +    .close         = socket_close,
> +    .shut_down     = socket_shutdown

Just including commas, even for the last item, helps in reducing the
number of changed lines..


		Amit