From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52529)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Y9WZ9-00022y-Bp
	for qemu-devel@nongnu.org; Fri, 09 Jan 2015 05:13:16 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Y9WZ6-0007ZQ-25
	for qemu-devel@nongnu.org; Fri, 09 Jan 2015 05:13:15 -0500
Received: from mail-we0-x232.google.com ([2a00:1450:400c:c03::232]:34475)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Y9WZ5-0007ZF-Sh
	for qemu-devel@nongnu.org; Fri, 09 Jan 2015 05:13:12 -0500
Received: by mail-we0-f178.google.com with SMTP id p10so7074119wes.9
	for <qemu-devel@nongnu.org>; Fri, 09 Jan 2015 02:13:11 -0800 (PST)
Date: Fri, 9 Jan 2015 10:13:08 +0000
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20150109101308.GB10417@stefanha-thinkpad.redhat.com>
References: <2168219.BKpqvL305g@normandy>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="A6N2fC+uXW/VQSAv"
Content-Disposition: inline
In-Reply-To: <2168219.BKpqvL305g@normandy>
Subject: Re: [Qemu-devel] [PATCH] NVMe: Set correct VS Value for 1.1
 Compliant Controllers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anubhav Rakshit <anubhav.rakshit@gmail.com>
Cc: Keith Busch <keith.busch@intel.com>, qemu-devel@nongnu.org


--A6N2fC+uXW/VQSAv
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jan 08, 2015 at 03:10:35PM +0530, Anubhav Rakshit wrote:
>=20
> According to NVMe specifications Bits 15:08 represent Minor Version numbe=
r.
>=20
> Signed-off-by: Anubhav Rakshit <anubhav.rakshit@gmail.com>
> ---
>  hw/block/nvme.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

I confirmed that the NVMe 1.1b specification wants 1000 and not 0001 for
the minor version.

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan

--A6N2fC+uXW/VQSAv
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJUr6m0AAoJEJykq7OBq3PICScH/3I9Txf+h7RWGGEZG7ycdJmV
LgPMzS8Xi0l2xCLKkJz5/1xr6XpevR28XGfIa+6PnB1x+bl6ZzADrodlkSmQyl12
SeUB0MHttNkd3c7j57qY7Fp62h+jR1fRvq/hgy4PDJ/gKXQMLw2T6MDKCn+ab/RX
fNMlDFaMW5SoLmqSasFxmPuI7gbCmTkLUiAdpGaAIENh7YKDmtoyEapVpTUfLhhK
5nebyxsX20bbNaD+/oMOqQ/OGdS1hX7Tfs1H7SMKIV5/KDOMKP3Hl/CcyX70v7bs
z7Af19rdv0QjPaR06xBhzmOCvybBuwPnJG/QlqYO9+t0iiK9Wz6LSOoNSYXW07c=
=CT+A
-----END PGP SIGNATURE-----

--A6N2fC+uXW/VQSAv--