Re: [Qemu-devel] [PATCH 01/14] libqos: Split apart pc_alloc_init

["Marc Marí" <marc.mari.barcelo@gmail.com>]

El Mon, 12 Jan 2015 22:34:26 -0500
John Snow <jsnow@redhat.com> escribió:
> Move the list-specific initialization over into
> malloc.c, to keep all of the list implementation
> details within the same file.
> 
> The allocation and freeing of these structures are
> now both back within the same layer.
> 
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>  tests/libqos/malloc-pc.c | 20 ++++----------------
>  tests/libqos/malloc.c    | 17 +++++++++++++++++
>  tests/libqos/malloc.h    |  1 +
>  3 files changed, 22 insertions(+), 16 deletions(-)
> 
> diff --git a/tests/libqos/malloc-pc.c b/tests/libqos/malloc-pc.c
> index c9c48fd..36a0740 100644
> --- a/tests/libqos/malloc-pc.c
> +++ b/tests/libqos/malloc-pc.c
> @@ -32,31 +32,19 @@ void pc_alloc_uninit(QGuestAllocator *allocator)
>  
>  QGuestAllocator *pc_alloc_init_flags(QAllocOpts flags)
>  {
> -    QGuestAllocator *s = g_malloc0(sizeof(*s));
> +    QGuestAllocator *s;
>      uint64_t ram_size;
>      QFWCFG *fw_cfg = pc_fw_cfg_init();
> -    MemBlock *node;
> +
> +    ram_size = qfw_cfg_get_u64(fw_cfg, FW_CFG_RAM_SIZE);
> +    s = alloc_init(1 << 20, MIN(ram_size, 0xE0000000));
>  
>      s->opts = flags;
>      s->page_size = PAGE_SIZE;

Is there a reason to leave page_size out of the function? (flags is
considered in a patch later, ok). I think it would be interesting to
have both, so pc_alloc_init_flags can forget about the fields in
QGuestAllocator.

Thanks
Marc