From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36065) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YBE3h-0002Ts-D2 for qemu-devel@nongnu.org; Tue, 13 Jan 2015 21:51:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YBE3T-0007J8-MW for qemu-devel@nongnu.org; Tue, 13 Jan 2015 21:51:49 -0500 Date: Wed, 14 Jan 2015 13:40:48 +1100 From: David Gibson Message-ID: <20150114024048.GS3654@voom.BigPond> References: <1420765371-25342-1-git-send-email-aik@ozlabs.ru> <54AFA7DD.1020803@redhat.com> <54AFCF42.1060206@ozlabs.ru> <54AFD0AD.1000707@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="iiZKCn1f/U0ES2iY" Content-Disposition: inline In-Reply-To: <54AFD0AD.1000707@redhat.com> Subject: Re: [Qemu-devel] [RFC PATCH] spapr_vio/spapr_iommu: Move VIO bypass where it belongs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Alexey Kardashevskiy , qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Alexander Graf --iiZKCn1f/U0ES2iY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 09, 2015 at 01:59:25PM +0100, Paolo Bonzini wrote: >=20 >=20 > On 09/01/2015 13:53, Alexey Kardashevskiy wrote: > >> > I think the minimum version should be 2 as well, because migrating f= rom > >> > version 1 will not set the bypass field correctly. > > This why the patch is "RFC" :) > >=20 > > I can keep the flag in TCETable which would be a bit ugly but won't bre= ak > > migration. Is there any better way to keep compatibility? >=20 > No, I don't think so. Alas, there doesn't seem to be. I have the same thing with my RTC patches, where I have to keep the rtc_offset field in the sPAPREnvironment just to grab it on migration from an older version and stuff it into the new device instead. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --iiZKCn1f/U0ES2iY Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUtdcwAAoJEGw4ysog2bOSmM0QANuD8JjAUPKCNPV4mYit6fGp FqVicGhkrumuYQTIzRHtwp6185q10oFb92BtLrHYkaZ03gLlFBb6iYjomFxd4gPt vOXXJMgf3wpTf8q3tpqhFi5jIjeoBbEk4shBOWR52ysZOOYhFRkw1hiCfJ270297 c6o4XVuyf9K8J8HT4FZVjgnveCZ9wJGcr9r2C193tHBhD6afjx89//coRIu9kWyD UPzueMYFdUiCU/dKGENl4NepFv9gDBbdNbgKi8ksXA0FkHol6dFhOFYNumIzHeKO iuCE96XN4dsvmE/fHgJrbhjxs08TDk3bw56vvy/tMknJZ7nfIT21gljpSSna5Pxg 5fiB4UGD1zckeMKAImKfoW48Sd4dD53KxL4exEC1WNo0bGooFLBiFEZ5sLwcdDvZ 7mtplliAFfQJ23d6q+YEaF6I/HeevThwVJQFiHnUilub6d+VAI26EOKb+awAxsky BI6DYsOR+1vvy39ubVnMJJrRE5qmsf1MUmtJdM6LJmB5+9e+p4UUaqqa19gtcTVh V6trYuFs3c3SYbOccICICsm7nkgcEZPsy9slDw2Y1es0ghCHcbKKqJHyGeqjgAmb /4IUMo5Wlpw1hoGbvuLrj/nzJC4yU3xD8ptN4/Ga+cOn8LL+NQIExLfe4jNeqZbu S2E0TP2yk9wXr6OZGdzY =jMQ+ -----END PGP SIGNATURE----- --iiZKCn1f/U0ES2iY--