From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41125) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YBOSd-00055S-Bl for qemu-devel@nongnu.org; Wed, 14 Jan 2015 08:58:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YBOSX-0008MI-7W for qemu-devel@nongnu.org; Wed, 14 Jan 2015 08:58:15 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55715) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YBOSW-0008M4-W7 for qemu-devel@nongnu.org; Wed, 14 Jan 2015 08:58:09 -0500 Date: Wed, 14 Jan 2015 13:57:57 +0000 From: Stefan Hajnoczi Message-ID: <20150114135757.GA26172@stefanha-thinkpad.redhat.com> References: <1418901484-12988-1-git-send-email-tumanova@linux.vnet.ibm.com> <5492F9F6.3060004@de.ibm.com> <20150102125747.GG10823@stefanha-thinkpad.redhat.com> <54B4D816.6010507@de.ibm.com> <87mw5nx8ag.fsf@blackfin.pond.sub.org> <20150113160403.GB26676@stefanha-thinkpad.redhat.com> <54B56CE3.6020309@de.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="r5Pyd7+fXNt84Ff3" Content-Disposition: inline In-Reply-To: <54B56CE3.6020309@de.ibm.com> Subject: Re: [Qemu-devel] [PATCH v5 0/5] Geometry and blocksize detection for backing devices. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christian Borntraeger Cc: kwolf@redhat.com, thuth@linux.vnet.ibm.com, Stefan Hajnoczi , Ekaterina Tumanova , Public KVM Mailing List , Markus Armbruster , dahi@linux.vnet.ibm.com, cornelia.huck@de.ibm.com, pbonzini@redhat.com, mihajlov@linux.vnet.ibm.com --r5Pyd7+fXNt84Ff3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 13, 2015 at 08:07:15PM +0100, Christian Borntraeger wrote: > Am 13.01.2015 um 17:04 schrieb Stefan Hajnoczi: > [...] > > I'm really starting to get worried that you are going to break things. > > This DASD hack is a layering violation but okay, go ahead if you want. > > But now you are also thinking about breaking live migration. > >=20 > > The proper thing to do is to introduce libvirt XML syntax for DASD. > > That way the geometry can be handled as part of the machine > > configuration. Then live migration and storage management tools can do > > the right thing. > >=20 > > I've said this should be done in libvirt repeatedly but you keep wanting > > to hack QEMU instead of doing this cleanly :(. > >=20 > > If you have plans to expand on this hack, please scrap this series and > > introduce libvirt XML syntax instead. >=20 > We had no plans to expand on this band-aid. I just tried to come up with = ideas beyond this hack to make this more acceptible to you (because I thoug= h that > you want something on top). Seems that I misunderstood you, so if you pr= efer > to just keep this hack and not do anything further in that direction, thi= s is > totally fine with me. >=20 > So lets just fix up the small nits and go ahead, ok? Yes, I'm fine with this series (modulo the review comments which require a v6). Stefan --r5Pyd7+fXNt84Ff3 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUtnXlAAoJEJykq7OBq3PITAUH/iFglWxwlRGENHzdJWHectvp 3fNTPx/a2UE5btwkD2qe6cceXHVZU5F4f2P8QPABDiNjP8G/pRrm/qqPUaE83MUk D1cE5GlvC03EVox4PVYmtuxKBN0yOLFOSwC0uzxj1TfEdA5PlQUsA/E2/qkoU58t IuZXH/sNSVu0w2GzBp+iYkEATegMSfJwjYPiKqmUCHhsLPsolt7qEXRlWAiyWJqa gbKcrr8bbh/aRvkSvz0b7HajHoUOYfXtFQfFCayh8TdRzZchXwS42eendMUdoHvo nJ470alVTmTgU1tDEz3NxClbUSfta6KUGtTqlTx5acPRlIkk9nCbBW82xHuBJ04= =/dXx -----END PGP SIGNATURE----- --r5Pyd7+fXNt84Ff3--