From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39595)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1YBgLo-0006N5-VN
	for qemu-devel@nongnu.org; Thu, 15 Jan 2015 04:04:25 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1YBgLl-0002dd-MA
	for qemu-devel@nongnu.org; Thu, 15 Jan 2015 04:04:24 -0500
Received: from mx1.redhat.com ([209.132.183.28]:56278)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1YBgLl-0002dN-Ej
	for qemu-devel@nongnu.org; Thu, 15 Jan 2015 04:04:21 -0500
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0F94IgM031890
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Thu, 15 Jan 2015 04:04:19 -0500
Date: Thu, 15 Jan 2015 14:34:14 +0530
From: Amit Shah <amit.shah@redhat.com>
Message-ID: <20150115090414.GA6102@grmbl.mre>
References: <1420711408-15766-1-git-send-email-pbonzini@redhat.com>
	<1420711408-15766-5-git-send-email-pbonzini@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1420711408-15766-5-git-send-email-pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 4/4] vmstate: accept QEMUTimer in
 VMSTATE_TIMER*, add VMSTATE_TIMER_PTR*
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org

On (Thu) 08 Jan 2015 [11:03:28], Paolo Bonzini wrote:
> Old users of VMSTATE_TIMER* are mechanically changed to VMSTATE_TIMER_PTR
> variants.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


> diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h
> index e45fc49..55ba584 100644
> --- a/include/migration/vmstate.h
> +++ b/include/migration/vmstate.h
> @@ -642,17 +642,29 @@ extern const VMStateInfo vmstate_info_bitmap;
>  #define VMSTATE_FLOAT64(_f, _s)                                       \
>      VMSTATE_FLOAT64_V(_f, _s, 0)
>  
> -#define VMSTATE_TIMER_TEST(_f, _s, _test)                             \
> +#define VMSTATE_TIMER_PTR_TEST(_f, _s, _test)                             \
>      VMSTATE_POINTER_TEST(_f, _s, _test, vmstate_info_timer, QEMUTimer *)
>  
> -#define VMSTATE_TIMER_V(_f, _s, _v)                                   \
> +#define VMSTATE_TIMER_PTR_V(_f, _s, _v)                                   \
>      VMSTATE_POINTER(_f, _s, _v, vmstate_info_timer, QEMUTimer *)
>  
> +#define VMSTATE_TIMER_PTR(_f, _s)                                         \
> +    VMSTATE_TIMER_PTR_V(_f, _s, 0)
> +
> +#define VMSTATE_TIMER_PTR_ARRAY(_f, _s, _n)                              \
> +    VMSTATE_ARRAY_OF_POINTER(_f, _s, _n, 0, vmstate_info_timer, QEMUTimer *)
> +
> +#define VMSTATE_TIMER_TEST(_f, _s, _test)                             \
> +    VMSTATE_SINGLE_TEST(_f, _s, _test, 0, vmstate_info_timer, QEMUTimer)
> +
> +#define VMSTATE_TIMER_V(_f, _s, _v)                                   \
> +    VMSTATE_SINGLE(_f, _s, _v, vmstate_info_timer, QEMUTimer)
> +
>  #define VMSTATE_TIMER(_f, _s)                                         \
>      VMSTATE_TIMER_V(_f, _s, 0)

Why leave this around?

		Amit