From: Stefan Hajnoczi <stefanha@gmail.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH 0/2] qed: additional input validation
Date: Thu, 15 Jan 2015 15:23:41 +0000 [thread overview]
Message-ID: <20150115152341.GD4005@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1421065893-18875-1-git-send-email-stefanha@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 974 bytes --]
On Mon, Jan 12, 2015 at 12:31:31PM +0000, Stefan Hajnoczi wrote:
> These patches add an overflow check and a test case for invalid QED headers.
> Note that this has no security impact because reading the backing filename is
> limited to sizeof(bs->backing_file).
>
> Stefan Hajnoczi (2):
> qed: check for header size overflow
> qemu-iotests: add 116 invalid QED input file tests
>
> block/qed.c | 6 +++
> tests/qemu-iotests/116 | 96 ++++++++++++++++++++++++++++++++++++++++++++++
> tests/qemu-iotests/116.out | 37 ++++++++++++++++++
> tests/qemu-iotests/group | 1 +
> 4 files changed, 140 insertions(+)
> create mode 100755 tests/qemu-iotests/116
> create mode 100644 tests/qemu-iotests/116.out
Kevin: Thanks for the style suggestion, I have applied your tweak. It
does read clearer when the expression checks UINT32_MAX.
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2015-01-15 15:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-12 12:31 [Qemu-devel] [PATCH 0/2] qed: additional input validation Stefan Hajnoczi
2015-01-12 12:31 ` [Qemu-devel] [PATCH 1/2] qed: check for header size overflow Stefan Hajnoczi
2015-01-14 14:00 ` Kevin Wolf
2015-01-12 12:31 ` [Qemu-devel] [PATCH 2/2] qemu-iotests: add 116 invalid QED input file tests Stefan Hajnoczi
2015-01-15 15:23 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150115152341.GD4005@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).