From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50309) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YBnHe-0002Gw-Qj for qemu-devel@nongnu.org; Thu, 15 Jan 2015 11:28:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YBnHZ-00073W-TP for qemu-devel@nongnu.org; Thu, 15 Jan 2015 11:28:34 -0500 Received: from mail-wi0-x233.google.com ([2a00:1450:400c:c05::233]:33461) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YBnHZ-00073M-Jj for qemu-devel@nongnu.org; Thu, 15 Jan 2015 11:28:29 -0500 Received: by mail-wi0-f179.google.com with SMTP id ho1so10565327wib.0 for ; Thu, 15 Jan 2015 08:28:28 -0800 (PST) Date: Thu, 15 Jan 2015 16:28:26 +0000 From: Stefan Hajnoczi Message-ID: <20150115162826.GF4005@stefanha-thinkpad.redhat.com> References: <1421139239-13968-1-git-send-email-famz@redhat.com> <1421139239-13968-2-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="4f28nU6agdXSinmL" Content-Disposition: inline In-Reply-To: <1421139239-13968-2-git-send-email-famz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 1/2] configure: Default to enable module build List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: Brian Jackson , Peter Maydell , Michael Tokarev , qemu-devel@nongnu.org, Stefan Hajnoczi , Bharata B Rao , Paolo Bonzini , Andreas =?iso-8859-1?Q?F=E4rber?= , Richard Henderson --4f28nU6agdXSinmL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 13, 2015 at 04:53:58PM +0800, Fam Zheng wrote: > We have module build support around for a while, but also had it bitrot > several times. It probably makes sense to enable it by default so that > people can notice and use it. >=20 > Counterpart to --enable-modules, which is turned as default, > --disable-modules is added to suppress it. If both are omitted, the > support is guesses as usual. "Add --disable-modules as a counterpart to --enable-modules, which is now turned on by default. If both are omitted, support is guessed as usual." >=20 > Signed-off-by: Fam Zheng > --- > configure | 95 ++++++++++++++++++++++++++++++++++++++++++++-------------= ------ > 1 file changed, 66 insertions(+), 29 deletions(-) >=20 > diff --git a/configure b/configure > index 7539645..8280e8a 100755 > --- a/configure > +++ b/configure > @@ -271,7 +271,7 @@ gcov_tool=3D"gcov" > EXESUF=3D"" > DSOSUF=3D".so" > LDFLAGS_SHARED=3D"-shared" > -modules=3D"no" > +modules=3D"" > prefix=3D"/usr/local" > mandir=3D"\${prefix}/share/man" > datadir=3D"\${prefix}/share" > @@ -768,6 +768,9 @@ for opt do > --enable-modules) > modules=3D"yes" > ;; > + --disable-modules) > + modules=3D"no" > + ;; > --cpu=3D*) > ;; > --target-list=3D*) target_list=3D"$optarg" > @@ -1259,7 +1262,8 @@ Advanced options (experts only): > --sysconfdir=3DPATH install config in PATH$confsuffix > --localstatedir=3DPATH install local state in PATH (set at runtime= on win32) > --with-confsuffix=3DSUFFIX suffix for QEMU data inside datadir/libdir/= sysconfdir [$confsuffix] > - --enable-modules enable modules support > + --enable-modules enable modules support (default) > + --disable-modules enable modules support > --enable-debug-tcg enable TCG debugging > --disable-debug-tcg disable TCG debugging (default) > --enable-debug-info enable debugging information (default) > @@ -2699,22 +2703,25 @@ if test "$mingw32" =3D yes; then > else > glib_req_ver=3D2.12 > fi > -glib_modules=3Dgthread-2.0 > -if test "$modules" =3D yes; then > - glib_modules=3D"$glib_modules gmodule-2.0" > -fi > =20 > -for i in $glib_modules; do > - if $pkg_config --atleast-version=3D$glib_req_ver $i; then > - glib_cflags=3D`$pkg_config --cflags $i` > - glib_libs=3D`$pkg_config --libs $i` > - CFLAGS=3D"$glib_cflags $CFLAGS" > - LIBS=3D"$glib_libs $LIBS" > - libs_qga=3D"$glib_libs $libs_qga" > - else > - error_exit "glib-$glib_req_ver $i is required to compile QEMU" > - fi > -done > +glib_module_try_config() I guess "module" here means glib package or component? It's a little confusing since gmodule-2.0 is needed for QEMU modular build support :). How about just glib_pkg_config()? > + if ! glib_module_try_config gmodule-2.0; then > + if $force; then > + error_exit "glib-$glib_req_ver gthread-2.0 is required to compile = QEMU" s/gthread-2.0/gmodule-2.0/ --4f28nU6agdXSinmL Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUt+qqAAoJEJykq7OBq3PIVq8H/3XgrXo+dKonYMsbRcN8OqYu Otj7kphKVCzBmppgVSbh03tnk8BUi7ndzhcryVNvUCYTCu0QpeTXBaRXwqnEQ7zc bZmqZ5d6WYanZ9Nn2udCaePIo7MecHx9mQJnGP4XAoIcyTovSTlGYWp/B4ZiiDWX sjuk/rx9uv106o42yO5uLkvIlgsiPmWshPdPxYiOIbv1DNns4a39FAg1XCO4f6GD qHlTy3XRFkW9AkwmAk3xNH5L8H7X41HCIRjlWqyUTDhro8rSSKWyrBCKG19DYIJL NsGa9mJceP6hS1P2q0xKlXnb1zQ+xnP6GKRDWvo0kciz+hUCyKbhAUHM63xDy6k= =LU2v -----END PGP SIGNATURE----- --4f28nU6agdXSinmL--