From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50862)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1YBwLv-0008Ge-RM
	for qemu-devel@nongnu.org; Thu, 15 Jan 2015 21:09:39 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1YBwHF-0001TR-S6
	for qemu-devel@nongnu.org; Thu, 15 Jan 2015 21:04:58 -0500
Received: from mx1.redhat.com ([209.132.183.28]:33864)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1YBwHF-0001TM-JI
	for qemu-devel@nongnu.org; Thu, 15 Jan 2015 21:04:45 -0500
Received: from int-mx14.intmail.prod.int.phx2.redhat.com
	(int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0G24iGD007724
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Thu, 15 Jan 2015 21:04:44 -0500
Date: Fri, 16 Jan 2015 10:04:39 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20150116020439.GD3079@ad.nay.redhat.com>
References: <1421171537-19118-1-git-send-email-pbonzini@redhat.com>
	<1421171537-19118-4-git-send-email-pbonzini@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1421171537-19118-4-git-send-email-pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/8] rcu: add rcutorture
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com

On Tue, 01/13 18:52, Paolo Bonzini wrote:
> +int main(int argc, char *argv[])
> +{
> +    int nreaders = 1;
> +    int duration = 1;
> +
> +    if (argc >= 2 && argv[1][0] == '-') {
> +        g_test_init(&argc, &argv, NULL);
> +        g_test_add_func("/rcu/torture/short/1reader", gtest_stress_1_1);
> +        g_test_add_func("/rcu/torture/short/10readers", gtest_stress_10_1);
> +        g_test_add_func("/rcu/torture/long/1reader", gtest_stress_1_5);
> +        g_test_add_func("/rcu/torture/long/10readers", gtest_stress_10_5);

Why do we need short tests when we have long tests? What are different other
than the durations?

> +        return g_test_run();
> +    }
> +
> +    if (argc >= 2) {
> +        nreaders = strtoul(argv[1], NULL, 0);
> +    }
> +    if (argc > 3) {
> +        duration = strtoul(argv[3], NULL, 0);
> +    }
> +    if (argc < 3 || strcmp(argv[2], "stress") == 0) {
> +        stresstest(nreaders, duration);
> +    } else if (strcmp(argv[2], "rperf") == 0) {
> +        rperftest(nreaders, duration);
> +    } else if (strcmp(argv[2], "uperf") == 0) {
> +        uperftest(nreaders, duration);
> +    } else if (strcmp(argv[2], "perf") == 0) {
> +        perftest(nreaders, duration);
> +    }
> +    usage(argc, argv);
> +    return 0;
> +}
> diff --git a/util/rcu.c b/util/rcu.c
> index f8f52ae..8df16d9 100644
> --- a/util/rcu.c
> +++ b/util/rcu.c
> @@ -169,5 +169,4 @@ static void __attribute__((__constructor__)) rcu_init(void)
>  {
>      qemu_mutex_init(&rcu_gp_lock);
>      qemu_event_init(&rcu_gp_event, true);
> -    rcu_register_thread();

Maybe don't add this line in patch 2?

Fam