From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52997) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YC6s1-0000Iw-W3 for qemu-devel@nongnu.org; Fri, 16 Jan 2015 08:23:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YC6ry-0003iF-Q4 for qemu-devel@nongnu.org; Fri, 16 Jan 2015 08:23:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51440) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YC6ry-0003i7-IJ for qemu-devel@nongnu.org; Fri, 16 Jan 2015 08:23:22 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0GDNL2E001752 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 16 Jan 2015 08:23:21 -0500 Date: Fri, 16 Jan 2015 13:23:19 +0000 From: Stefan Hajnoczi Message-ID: <20150116132319.GA32469@stefanha-thinkpad.redhat.com> References: <1421372322-17829-1-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="6TrnltStXW4iwmi0" Content-Disposition: inline In-Reply-To: <1421372322-17829-1-git-send-email-famz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2] qemu-iotests: Fix supported_oses check List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: Kevin Wolf , qemu-devel@nongnu.org --6TrnltStXW4iwmi0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 16, 2015 at 09:38:42AM +0800, Fam Zheng wrote: > There is a bug in the recently added sys.platform test, and we no longer > run python tests, because "linux2" is the value to compare here. So do a > prefix match. According to python doc [1], the way to use sys.platform > is "unless you want to test for a specific system version, it is > therefore recommended to use the following idiom": >=20 > if sys.platform.startswith('freebsd'): > # FreeBSD-specific code here... > elif sys.platform.startswith('linux'): > # Linux-specific code here... >=20 > [1]: https://docs.python.org/2.7/library/sys.html#sys.platform >=20 > Signed-off-by: Fam Zheng >=20 > --- > v2: Don't use any(). > Explain why prefix match is fine. > (Thanks, Stefan) > --- > tests/qemu-iotests/iotests.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan --6TrnltStXW4iwmi0 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUuRDGAAoJEJykq7OBq3PI61oH/jtU4LmNULw24C1DSR68kOEC r3zmgX1BaPxqUPeMN64BjD5Jga0spyH12eXnfkE5VAwfZn0k3GVnJYyawy8pEKbz 5k1w5+TY6D8LNYFbwqpJUveO/B07PovJoVaTAZGy54lEe3wRG46/FwHAcQji5nnf OHX4erqWPfp3+utPHQbRtiFyimEYHBtggZNyP3PeCIugB58xIzL7ZQ1S98lNvzMF WB3kOzhNncZzkY3PDgWRxz9erzFSyneiQ1In67cLuiu6v1S9Gl7vt2dD7hVNQp07 AFSwGT2mALxjdXySuGDJ4R1S5P94rpPWhT7CMaJr5ugCKh6zBPWVOZSyVHCUIOI= =kz5C -----END PGP SIGNATURE----- --6TrnltStXW4iwmi0--