From: Stefan Hajnoczi <stefanha@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qtest: Fix deadloop by running main loop AIO context's timers
Date: Fri, 16 Jan 2015 13:26:11 +0000 [thread overview]
Message-ID: <20150116132611.GC32469@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1421395277-3813-1-git-send-email-famz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 664 bytes --]
On Fri, Jan 16, 2015 at 04:01:17PM +0800, Fam Zheng wrote:
> qemu_clock_run_timers() only takes care of main_loop_tlg, we shouldn't
> forget aio timer list groups.
>
> Currently, the qemu_clock_deadline_ns_all (a few lines above) counts all
> the timergroups of this clock type, including aio tlg, but we don't fire
> them, so they are never cleared, which makes a dead loop.
>
> For example, this function hangs when trying to drive throttled block
> request queue with qtest clock_step.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> cpus.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-01-16 13:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-16 8:01 [Qemu-devel] [PATCH] qtest: Fix deadloop by running main loop AIO context's timers Fam Zheng
2015-01-16 13:26 ` Stefan Hajnoczi [this message]
2015-01-19 9:29 ` Paolo Bonzini
2015-01-19 9:48 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150116132611.GC32469@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=famz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).