* [Qemu-devel] [PATCH] qtest: Fix deadloop by running main loop AIO context's timers
@ 2015-01-16 8:01 Fam Zheng
2015-01-16 13:26 ` Stefan Hajnoczi
2015-01-19 9:29 ` Paolo Bonzini
0 siblings, 2 replies; 4+ messages in thread
From: Fam Zheng @ 2015-01-16 8:01 UTC (permalink / raw)
To: qemu-devel; +Cc: Paolo Bonzini, qemu-stable, Stefan Hajnoczi
qemu_clock_run_timers() only takes care of main_loop_tlg, we shouldn't
forget aio timer list groups.
Currently, the qemu_clock_deadline_ns_all (a few lines above) counts all
the timergroups of this clock type, including aio tlg, but we don't fire
them, so they are never cleared, which makes a dead loop.
For example, this function hangs when trying to drive throttled block
request queue with qtest clock_step.
Signed-off-by: Fam Zheng <famz@redhat.com>
---
cpus.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/cpus.c b/cpus.c
index 3a5323b..dd7e595 100644
--- a/cpus.c
+++ b/cpus.c
@@ -387,6 +387,7 @@ void qtest_clock_warp(int64_t dest)
seqlock_write_unlock(&timers_state.vm_clock_seqlock);
qemu_clock_run_timers(QEMU_CLOCK_VIRTUAL);
+ timerlistgroup_run_timers(&qemu_get_aio_context()->tlg);
clock = qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL);
}
qemu_clock_notify(QEMU_CLOCK_VIRTUAL);
--
1.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] qtest: Fix deadloop by running main loop AIO context's timers
2015-01-16 8:01 [Qemu-devel] [PATCH] qtest: Fix deadloop by running main loop AIO context's timers Fam Zheng
@ 2015-01-16 13:26 ` Stefan Hajnoczi
2015-01-19 9:29 ` Paolo Bonzini
1 sibling, 0 replies; 4+ messages in thread
From: Stefan Hajnoczi @ 2015-01-16 13:26 UTC (permalink / raw)
To: Fam Zheng; +Cc: Paolo Bonzini, qemu-devel, qemu-stable
[-- Attachment #1: Type: text/plain, Size: 664 bytes --]
On Fri, Jan 16, 2015 at 04:01:17PM +0800, Fam Zheng wrote:
> qemu_clock_run_timers() only takes care of main_loop_tlg, we shouldn't
> forget aio timer list groups.
>
> Currently, the qemu_clock_deadline_ns_all (a few lines above) counts all
> the timergroups of this clock type, including aio tlg, but we don't fire
> them, so they are never cleared, which makes a dead loop.
>
> For example, this function hangs when trying to drive throttled block
> request queue with qtest clock_step.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> cpus.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] qtest: Fix deadloop by running main loop AIO context's timers
2015-01-16 8:01 [Qemu-devel] [PATCH] qtest: Fix deadloop by running main loop AIO context's timers Fam Zheng
2015-01-16 13:26 ` Stefan Hajnoczi
@ 2015-01-19 9:29 ` Paolo Bonzini
2015-01-19 9:48 ` Fam Zheng
1 sibling, 1 reply; 4+ messages in thread
From: Paolo Bonzini @ 2015-01-19 9:29 UTC (permalink / raw)
To: Fam Zheng, qemu-devel; +Cc: qemu-stable, Stefan Hajnoczi
On 16/01/2015 09:01, Fam Zheng wrote:
> qemu_clock_run_timers() only takes care of main_loop_tlg, we shouldn't
> forget aio timer list groups.
>
> Currently, the qemu_clock_deadline_ns_all (a few lines above) counts all
> the timergroups of this clock type, including aio tlg, but we don't fire
> them, so they are never cleared, which makes a dead loop.
>
> For example, this function hangs when trying to drive throttled block
> request queue with qtest clock_step.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> cpus.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/cpus.c b/cpus.c
> index 3a5323b..dd7e595 100644
> --- a/cpus.c
> +++ b/cpus.c
> @@ -387,6 +387,7 @@ void qtest_clock_warp(int64_t dest)
> seqlock_write_unlock(&timers_state.vm_clock_seqlock);
>
> qemu_clock_run_timers(QEMU_CLOCK_VIRTUAL);
> + timerlistgroup_run_timers(&qemu_get_aio_context()->tlg);
Good catch. However, I think it's enough to run the QEMU_CLOCK_VIRTUAL
events, using timerlist_run_timers.
Thanks,
Paolo
> clock = qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL);
> }
> qemu_clock_notify(QEMU_CLOCK_VIRTUAL);
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] qtest: Fix deadloop by running main loop AIO context's timers
2015-01-19 9:29 ` Paolo Bonzini
@ 2015-01-19 9:48 ` Fam Zheng
0 siblings, 0 replies; 4+ messages in thread
From: Fam Zheng @ 2015-01-19 9:48 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-devel, Stefan Hajnoczi, qemu-stable
On Mon, 01/19 10:29, Paolo Bonzini wrote:
>
>
> On 16/01/2015 09:01, Fam Zheng wrote:
> > qemu_clock_run_timers() only takes care of main_loop_tlg, we shouldn't
> > forget aio timer list groups.
> >
> > Currently, the qemu_clock_deadline_ns_all (a few lines above) counts all
> > the timergroups of this clock type, including aio tlg, but we don't fire
> > them, so they are never cleared, which makes a dead loop.
> >
> > For example, this function hangs when trying to drive throttled block
> > request queue with qtest clock_step.
> >
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> > ---
> > cpus.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/cpus.c b/cpus.c
> > index 3a5323b..dd7e595 100644
> > --- a/cpus.c
> > +++ b/cpus.c
> > @@ -387,6 +387,7 @@ void qtest_clock_warp(int64_t dest)
> > seqlock_write_unlock(&timers_state.vm_clock_seqlock);
> >
> > qemu_clock_run_timers(QEMU_CLOCK_VIRTUAL);
> > + timerlistgroup_run_timers(&qemu_get_aio_context()->tlg);
>
> Good catch. However, I think it's enough to run the QEMU_CLOCK_VIRTUAL
> events, using timerlist_run_timers.
OK, will fix!
Fam
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-01-19 9:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-16 8:01 [Qemu-devel] [PATCH] qtest: Fix deadloop by running main loop AIO context's timers Fam Zheng
2015-01-16 13:26 ` Stefan Hajnoczi
2015-01-19 9:29 ` Paolo Bonzini
2015-01-19 9:48 ` Fam Zheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).