From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53525) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YC6ur-000364-0W for qemu-devel@nongnu.org; Fri, 16 Jan 2015 08:26:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YC6ul-0004VZ-RA for qemu-devel@nongnu.org; Fri, 16 Jan 2015 08:26:20 -0500 Date: Fri, 16 Jan 2015 13:26:11 +0000 From: Stefan Hajnoczi Message-ID: <20150116132611.GC32469@stefanha-thinkpad.redhat.com> References: <1421395277-3813-1-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Izn7cH1Com+I3R9J" Content-Disposition: inline In-Reply-To: <1421395277-3813-1-git-send-email-famz@redhat.com> Subject: Re: [Qemu-devel] [PATCH] qtest: Fix deadloop by running main loop AIO context's timers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: Paolo Bonzini , qemu-devel@nongnu.org, qemu-stable@nongnu.org --Izn7cH1Com+I3R9J Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 16, 2015 at 04:01:17PM +0800, Fam Zheng wrote: > qemu_clock_run_timers() only takes care of main_loop_tlg, we shouldn't > forget aio timer list groups. >=20 > Currently, the qemu_clock_deadline_ns_all (a few lines above) counts all > the timergroups of this clock type, including aio tlg, but we don't fire > them, so they are never cleared, which makes a dead loop. >=20 > For example, this function hangs when trying to drive throttled block > request queue with qtest clock_step. >=20 > Signed-off-by: Fam Zheng > --- > cpus.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Stefan Hajnoczi --Izn7cH1Com+I3R9J Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUuRFzAAoJEJykq7OBq3PIwIAIAKEEWjmPpdBtaF57di7xHFH/ 5vQHUYM60jxvr/I8CVUZ7zTPqpt92LeKj7vn6a6eEoVqd34Vmwa6jbYsOM1F3Qlv kgPBovs3gW6w+cEUn5//tGiZRD7ldNsw5QMmUEf6qoTxnuSofEqi8oV8e9LOo3rX 1kv9b1HUPpsg+GgKqIoEKxAhDkQbhtQUq988APbUjGEo6VuhVKkYDLiYsWV2AbHP qFfKMKQYzh11Vvbqgjk7wSCULeuTYjtTo56ySHJMqiHZUf3QPF8qAHOJFIrVSq3W wqZDbW9Ph3axTg/Q5CY9tO4l4yaEbTacBLtUa+FoHKPn2f/xMbnJCsBoYSDXfqo= =ac8n -----END PGP SIGNATURE----- --Izn7cH1Com+I3R9J--