From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43689) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YD5Ls-0007qH-Ub for qemu-devel@nongnu.org; Mon, 19 Jan 2015 00:58:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YD5Lp-00028b-Fk for qemu-devel@nongnu.org; Mon, 19 Jan 2015 00:58:16 -0500 Date: Mon, 19 Jan 2015 16:22:54 +1100 From: David Gibson Message-ID: <20150119052254.GX5297@voom.fritz.box> References: <1419337831-16552-1-git-send-email-mdroth@linux.vnet.ibm.com> <1419337831-16552-15-git-send-email-mdroth@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="72btQdUC6twB1rwh" Content-Disposition: inline In-Reply-To: <1419337831-16552-15-git-send-email-mdroth@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v4 14/17] spapr_pci: populate DRC dt entries for PHBs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: aik@ozlabs.ru, qemu-devel@nongnu.org, agraf@suse.de, ncmike@ncultra.org, qemu-ppc@nongnu.org, tyreld@linux.vnet.ibm.com, bharata.rao@gmail.com, nfont@linux.vnet.ibm.com --72btQdUC6twB1rwh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 23, 2014 at 06:30:28AM -0600, Michael Roth wrote: > Reserve 32 entries of type PCI in each PHB's initial FDT. This > advertises to guests that each PHB is DR-capable device with > physical hotpluggable slots. This is necessary for allowing > hotplugging of devices to it later via bus rescan or guest rpaphp > hotplug module. >=20 > Signed-off-by: Michael Roth > --- > hw/ppc/spapr_pci.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) >=20 > diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c > index 73e86a4..a5d7791 100644 > --- a/hw/ppc/spapr_pci.c > +++ b/hw/ppc/spapr_pci.c > @@ -47,6 +47,8 @@ > #define RTAS_TYPE_MSI 1 > #define RTAS_TYPE_MSIX 2 > =20 > +#define FDT_MAX_SIZE 0x10000 This define doesn't appear to be used in the new code. > #include "hw/ppc/spapr_drc.h" > =20 > static sPAPRPHBState *find_phb(sPAPREnvironment *spapr, uint64_t buid) > @@ -872,7 +874,7 @@ int spapr_populate_pci_dt(sPAPRPHBState *phb, > uint32_t xics_phandle, > void *fdt) > { > - int bus_off, i, j; > + int bus_off, i, j, ret; > char nodename[256]; > uint32_t bus_range[] =3D { cpu_to_be32(0), cpu_to_be32(0xff) }; > struct { > @@ -951,6 +953,11 @@ int spapr_populate_pci_dt(sPAPRPHBState *phb, > object_child_foreach(OBJECT(phb), spapr_phb_children_dt, > &((sPAPRTCEDT){ .fdt =3D fdt, .node_off =3D bus= _off })); > =20 > + ret =3D spapr_drc_populate_dt(fdt, bus_off, SPAPR_DR_CONNECTOR_TYPE_= PCI); AFAICT this will add information for all PCI connectors in the system. Shouldn't it only add the ones belonging to this PHB? --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --72btQdUC6twB1rwh Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUvJSuAAoJEGw4ysog2bOSP3IQAIB+FPMsJDkFgFPxtzmO/hHR WDyjO3+/KEPSPX4qTJPYSJ71WWZdD89sDMmRhaBSVXRDcIDZXs162obOh3FOGVu2 /VoebYJrCZiaofy98mlj1OVj5/oD5TMn6HuTq/yltpS0IA2Q7v1BJ3UpuryXNAqe v6CfZYy6/NF8WtvEKOUgKAabReVeNDOe+PcedqOpL/pojpZtjZmE+j0f3l4xnLRU 2v9WrXCnbSY/J0uHNpnysTBA293OMfWBU/Y/J7yaTbE0+45XoJ3f0HKnllfaj+R1 D236bH986OoAch3nXEzRWeieO6yCpSkstv1VB5/LiRuH/9DHqBSwFNhHguyUbgdw 8vjzDIlEB2RCQZvFutkzNR7m3dud+t1JKd2vFBZr4J+wcv4HMhqcxO8uJe/EiDeM hyBRSRZRDbD36Kyw6CC6R68Dfyjh3BzZwNsvfbTa6CFMATKFbRyKHBkgeEyPGf9Q JAUV2lfiD0vuDW1LhrSZ1yvNi+BtwCsvMUBsf9bZysrSuC3A40aPLIemnpoOA7UR Qa+uiEVnFHfmAet1PJazCWW35yPOIrnDlriwB5rwuEpSLi5rYPLDim1/z8DkgyYU ZogPH/0hzjqoksw0LsjlTaS5t7yXHCJE2iN84yk28Vquen8xXYuBnmFNbHU/xYvL /zFgxLbvX2O9Cj96eRp2 =Dxnv -----END PGP SIGNATURE----- --72btQdUC6twB1rwh--