From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43720) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YD5Lv-0007qn-BG for qemu-devel@nongnu.org; Mon, 19 Jan 2015 00:58:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YD5Lq-000294-Lr for qemu-devel@nongnu.org; Mon, 19 Jan 2015 00:58:19 -0500 Date: Mon, 19 Jan 2015 16:24:42 +1100 From: David Gibson Message-ID: <20150119052441.GY5297@voom.fritz.box> References: <1419337831-16552-1-git-send-email-mdroth@linux.vnet.ibm.com> <1419337831-16552-16-git-send-email-mdroth@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="dZHW955j1vPFHE0Q" Content-Disposition: inline In-Reply-To: <1419337831-16552-16-git-send-email-mdroth@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v4 15/17] pci: make pci_bar useable outside pci.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: aik@ozlabs.ru, qemu-devel@nongnu.org, agraf@suse.de, ncmike@ncultra.org, qemu-ppc@nongnu.org, tyreld@linux.vnet.ibm.com, bharata.rao@gmail.com, nfont@linux.vnet.ibm.com --dZHW955j1vPFHE0Q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 23, 2014 at 06:30:29AM -0600, Michael Roth wrote: You need a commit message with a rationale for this. > Signed-off-by: Michael Roth > --- > hw/pci/pci.c | 2 +- > include/hw/pci/pci.h | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/hw/pci/pci.c b/hw/pci/pci.c > index 371699c..bf16fc8 100644 > --- a/hw/pci/pci.c > +++ b/hw/pci/pci.c > @@ -122,7 +122,7 @@ static uint16_t pci_default_sub_device_id =3D PCI_SUB= DEVICE_ID_QEMU; > =20 > static QLIST_HEAD(, PCIHostState) pci_host_bridges; > =20 > -static int pci_bar(PCIDevice *d, int reg) > +int pci_bar(PCIDevice *d, int reg) > { > uint8_t type; > =20 > diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h > index 97e4257..ae7c3fc 100644 > --- a/include/hw/pci/pci.h > +++ b/include/hw/pci/pci.h > @@ -330,6 +330,7 @@ void pci_device_save(PCIDevice *s, QEMUFile *f); > int pci_device_load(PCIDevice *s, QEMUFile *f); > MemoryRegion *pci_address_space(PCIDevice *dev); > MemoryRegion *pci_address_space_io(PCIDevice *dev); > +int pci_bar(PCIDevice *d, int reg); > =20 > typedef void (*pci_set_irq_fn)(void *opaque, int irq_num, int level); > typedef int (*pci_map_irq_fn)(PCIDevice *pci_dev, int irq_num); --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --dZHW955j1vPFHE0Q Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUvJUZAAoJEGw4ysog2bOSgpEQALf9N2e7flMM+gnFQGAMRCkU ZI3srigk3kNooAGh49NNBe/xg4iWSbT2x/kVq3MDJSSKB4ulZAmTxJl2LFa+rGD2 gsoLMmc6kuaSqGL1LPY4LgERCOjGjGw/3XF8QFmW9oma/61fJkTn78Wi8YclQpvs uUGJnE4sK/wYbrWBeFmYjiMzM5D3CyrtIXUSrnaLY5UBq/wGK4YbfjtX4sekKvSY MTzV3CnHynVpxQBc5gKED2P6MgYOKCdkvgD78Hwx+aFTXMTekpZJ+jaRlGJIo6SX Ku/mdMdWb/VsVmBHPJqpoUg8fLAaNlV2Pm3cdKBZb5Lynp2vuym4ve2dZ5tDNnnc 1HMUGgbvpJkXsYKvatZOUF24eymok6soVNpmH52iFYz7TT8k94VJYMZS8Rv3aTyb kDCCrmZn8zKrdRimCri++c4HKGAyB/yHogn8xvkndqzsoR2X5vfPjWnRTMSjXBUh 77YbFSbMLW/FdMYJAOEzR96W37P8dBD4FFyf3JuFVb59P8tt5yvQZYnZ814UBCFR 8+55rQK1wGd8iVo64I/4MCJ1/7mTYSFaK7Vusv1eSXijEtnSE1G4jyVC5jNItjxJ leNrXHaLSDuWk1ifIevzZoV/hczr1c+woPa7xcGauSyqz9p7M/ip3UdZJSiy+EA3 iFYSEZM+Bj0GXZ0zVXdQ =WFbL -----END PGP SIGNATURE----- --dZHW955j1vPFHE0Q--