From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40477) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDBjP-0005U7-5N for qemu-devel@nongnu.org; Mon, 19 Jan 2015 07:46:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YDBjK-0000m7-4T for qemu-devel@nongnu.org; Mon, 19 Jan 2015 07:46:59 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53268) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDBjJ-0000ln-E2 for qemu-devel@nongnu.org; Mon, 19 Jan 2015 07:46:53 -0500 Date: Mon, 19 Jan 2015 14:46:38 +0200 From: "Michael S. Tsirkin" Message-ID: <20150119124638.GA27158@redhat.com> References: <1418989624-12049-1-git-send-email-imammedo@redhat.com> <1418989624-12049-3-git-send-email-imammedo@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1418989624-12049-3-git-send-email-imammedo@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 2/8] pc: acpi: decribe bridge device as not hotpluggable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: claudio.fontana@huawei.com, qemu-devel@nongnu.org, marcel.a@redhat.com On Fri, Dec 19, 2014 at 11:46:58AM +0000, Igor Mammedov wrote: > when bridge hotplug is disabled, i.e. for machine > types less then 2.0, bridge device was created as > hotpluggable by mistake since commit 133a2da (2.1). > Fix it by just creating it as a present device as > it was done in 1.7. > > Signed-off-by: Igor Mammedov I still don't get this. Under 1.7 all devices are hotpluggable unless disabled by device class. Bridges were hotpluggable too. See 72c194f7e75cb64b2558111cb111adb49fbf4097, function acpi_get_hotplug_info. So if the idea is to match 1.7, this does not do it. What, then, is the purpose of this patch? > --- > hw/i386/acpi-build.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > index a4d0c0c..c151fde 100644 > --- a/hw/i386/acpi-build.c > +++ b/hw/i386/acpi-build.c > @@ -919,7 +919,7 @@ static void build_pci_bus_end(PCIBus *bus, void *bus_state) > } > } > > - if (!dc->hotpluggable || bridge_in_acpi) { > + if (!dc->hotpluggable || pc->is_bridge) { > clear_bit(slot, slot_hotplug_enable); > } > } > -- > 1.8.3.1 >