From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50788)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1YDW1W-0002a3-S1
	for qemu-devel@nongnu.org; Tue, 20 Jan 2015 05:27:03 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1YDW1R-0007ia-V7
	for qemu-devel@nongnu.org; Tue, 20 Jan 2015 05:27:02 -0500
Received: from mx1.redhat.com ([209.132.183.28]:35872)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1YDW1R-0007iD-Og
	for qemu-devel@nongnu.org; Tue, 20 Jan 2015 05:26:57 -0500
Date: Tue, 20 Jan 2015 10:26:47 +0000
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20150120102647.GD17631@stefanha-thinkpad.redhat.com>
References: <1421422633-25536-1-git-send-email-stefanha@redhat.com>
	<CAFEAcA-Ageq02CX92dVaSbw_38i8xK91mUD=1XxCc+HhuhtCtw@mail.gmail.com>
	<1497100.KaIgobZClN@al>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="5gxpn/Q6ypwruk0T"
Content-Disposition: inline
In-Reply-To: <1497100.KaIgobZClN@al>
Subject: Re: [Qemu-devel] [PULL 00/16] Block patches
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Wu <peter@lekensteyn.nl>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org


--5gxpn/Q6ypwruk0T
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Jan 17, 2015 at 11:41:59AM +0100, Peter Wu wrote:
> On Friday 16 January 2015 16:46:39 Peter Maydell wrote:
> > CentOS5:
> >=20
> > ../block/dmg.o: In function `dmg_read_plist_xml':
> > /home/petmay01/linaro/qemu-for-merges/block/dmg.c:414: undefined
> > reference to `g_base64_decode_inplace'
>=20
> Should have paid more attention to the API docs. Can you try the
> following patch? It still passes 4 dmg tests for me
> (https://lekensteyn.nl/files/dmg-tests/).

Could you also replace g_assert_false() with g_assert(!...) so it builds
on Mac?

Thanks,
Stefan

--5gxpn/Q6ypwruk0T
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJUvi1nAAoJEJykq7OBq3PIclMIAKmZu3JwruExmV+V5ZIBPm0s
9Dbe97MkhLX8o1lJzL63G5945IMg7HG25ul9TaJkcu8oTRg+HeBTb+B3QxbUzjs7
vfXkYxhqXG21l83DcvdONvqI3JUUkS2Qqdj12ds6oFx4uDNpfRs75EWdViS7twx5
PxKL4KZs3kj5sqUfa4K1FRvNymEjghRXWD5CtNzqJo7dj9895Ia+RagSDguF9ZcO
AxFDADavjwbOAO8TDDBCvBEGdoq3/IPV9RhkcBNTpHgSmakGKYRRiVhgq6Ku3tH9
ZJa3Avks3GWE75vSNQNfP6kehwE8MSLPxpRwsyMX0TgKIiUJn3QgWJctwDeKqNk=
=nRXV
-----END PGP SIGNATURE-----

--5gxpn/Q6ypwruk0T--