Re: [Qemu-devel] [RESEND PATCH v1 0/5] Common unplug and unplug request cb for memory and CPU hot-unplug.

[Igor Mammedov <imammedo@redhat.com>]

On Mon, 19 Jan 2015 23:29:37 +0200
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> On Wed, Jan 07, 2015 at 02:49:40PM +0800, Tang Chen wrote:
> > Memory and CPU hot unplug are both asynchronize procedures.
> > When the unplug operation happens, unplug request cb is called first.
> > And when ghest OS finished handling unplug, unplug cb will be called
> > to do the real removal of device.
> > 
> > They both need pc-machine, piix4 and ich9 unplug and unplug request cb.
> > So this patch set introduces these commom functions as part1, and memory
> > and CPU hot-unplug will come soon as part 2 and 3.
> > 
> > This patch-set is based on QEmu 2.2
> 
> OK, Igor - you only have comments for the commit log?
> I take this as implicit ack of the patches?
> If so pls let me know.
Yes, patches themselves are good.
Can fixup commit messages and add author SoBs to them, before
applying or should we wait for respin?


> > Tang Chen (5):
> >   acpi, pc: Add hotunplug request cb for pc machine.
> >   acpi, ich9: Add hotunplug request cb for ich9.
> >   acpi, pc: Add unplug cb for pc machine.
> >   acpi, ich9: Add unplug cb for ich9.
> >   acpi, piix4: Add unplug cb for piix4.
> > 
> >  hw/acpi/ich9.c         | 14 ++++++++++++++
> >  hw/acpi/piix4.c        |  8 ++++++++
> >  hw/i386/pc.c           | 16 ++++++++++++++++
> >  hw/isa/lpc_ich9.c      | 14 ++++++++++++--
> >  include/hw/acpi/ich9.h |  4 ++++
> >  5 files changed, 54 insertions(+), 2 deletions(-)
> > 
> > -- 
> > 1.8.4.2