From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45318) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDVeb-0004yh-TG for qemu-devel@nongnu.org; Tue, 20 Jan 2015 05:03:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YDVeV-0007rX-S5 for qemu-devel@nongnu.org; Tue, 20 Jan 2015 05:03:21 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52224) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDVeV-0007rQ-Jq for qemu-devel@nongnu.org; Tue, 20 Jan 2015 05:03:15 -0500 Date: Tue, 20 Jan 2015 11:03:02 +0100 From: Igor Mammedov Message-ID: <20150120110302.64dfcde3@nial.brq.redhat.com> In-Reply-To: <20150119212937.GA10385@redhat.com> References: <1420613385-13679-1-git-send-email-tangchen@cn.fujitsu.com> <20150119212937.GA10385@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RESEND PATCH v1 0/5] Common unplug and unplug request cb for memory and CPU hot-unplug. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: zhugh.fnst@cn.fujitsu.com, hutao@cn.fujitsu.com, qemu-devel@nongnu.org, Tang Chen , isimatu.yasuaki@jp.fujitsu.com, guz.fnst@cn.fujitsu.com, pbonzini@redhat.com On Mon, 19 Jan 2015 23:29:37 +0200 "Michael S. Tsirkin" wrote: > On Wed, Jan 07, 2015 at 02:49:40PM +0800, Tang Chen wrote: > > Memory and CPU hot unplug are both asynchronize procedures. > > When the unplug operation happens, unplug request cb is called first. > > And when ghest OS finished handling unplug, unplug cb will be called > > to do the real removal of device. > > > > They both need pc-machine, piix4 and ich9 unplug and unplug request cb. > > So this patch set introduces these commom functions as part1, and memory > > and CPU hot-unplug will come soon as part 2 and 3. > > > > This patch-set is based on QEmu 2.2 > > OK, Igor - you only have comments for the commit log? > I take this as implicit ack of the patches? > If so pls let me know. Yes, patches themselves are good. Can fixup commit messages and add author SoBs to them, before applying or should we wait for respin? > > Tang Chen (5): > > acpi, pc: Add hotunplug request cb for pc machine. > > acpi, ich9: Add hotunplug request cb for ich9. > > acpi, pc: Add unplug cb for pc machine. > > acpi, ich9: Add unplug cb for ich9. > > acpi, piix4: Add unplug cb for piix4. > > > > hw/acpi/ich9.c | 14 ++++++++++++++ > > hw/acpi/piix4.c | 8 ++++++++ > > hw/i386/pc.c | 16 ++++++++++++++++ > > hw/isa/lpc_ich9.c | 14 ++++++++++++-- > > include/hw/acpi/ich9.h | 4 ++++ > > 5 files changed, 54 insertions(+), 2 deletions(-) > > > > -- > > 1.8.4.2