From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35423) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDYhL-0005x7-PN for qemu-devel@nongnu.org; Tue, 20 Jan 2015 08:18:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YDYhG-0007ZN-Al for qemu-devel@nongnu.org; Tue, 20 Jan 2015 08:18:23 -0500 Received: from mail-wi0-x235.google.com ([2a00:1450:400c:c05::235]:44953) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDYhG-0007Xf-37 for qemu-devel@nongnu.org; Tue, 20 Jan 2015 08:18:18 -0500 Received: by mail-wi0-f181.google.com with SMTP id fb4so10841123wid.2 for ; Tue, 20 Jan 2015 05:18:17 -0800 (PST) Date: Tue, 20 Jan 2015 13:18:14 +0000 From: Stefan Hajnoczi Message-ID: <20150120131814.GN17631@stefanha-thinkpad.redhat.com> References: <1418304322-7546-1-git-send-email-cornelia.huck@de.ibm.com> <1418304322-7546-17-git-send-email-cornelia.huck@de.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="WeDu0lr7bteb/II5" Content-Disposition: inline In-Reply-To: <1418304322-7546-17-git-send-email-cornelia.huck@de.ibm.com> Subject: Re: [Qemu-devel] [PATCH RFC v6 16/20] virtio-net: support longer header List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: thuth@linux.vnet.ibm.com, mst@redhat.com, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org --WeDu0lr7bteb/II5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 11, 2014 at 02:25:18PM +0100, Cornelia Huck wrote: > diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c > index ebbea60..7ee2bd6 100644 > --- a/hw/net/virtio-net.c > +++ b/hw/net/virtio-net.c > @@ -373,15 +373,21 @@ static int peer_has_ufo(VirtIONet *n) > return n->has_ufo; > } > =20 > -static void virtio_net_set_mrg_rx_bufs(VirtIONet *n, int mergeable_rx_bu= fs) > +static void virtio_net_set_mrg_rx_bufs(VirtIONet *n, int mergeable_rx_bu= fs, > + int version_1) Please use bool, it makes it 100% clear what the meaning of "version_1" is. s/int/bool/ --WeDu0lr7bteb/II5 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUvlWWAAoJEJykq7OBq3PIGCkIAKC+xXe71e3QQKzFpyuADXsV 0/swDG95FPkgI094wpj21y8AYYm6x2QiZOnnRph+c0rzxrt4n+SK8d9/0fzBJhCa T9waiWC3MDFkONAceOO2oUMMV00dWjbebpyuDu3/izKshWzKNJ4vP6tdaJZODQLq W4263o6BF3fe+7vGpofcS0tCDhBiDJRb+k+0vLp0vePeKVDC9IZ/G4gdf/rfa1g2 wLp9d2GLCq21RWYW+Bo7BokyrhR/MMtzuttZs3gZQ00Bk4jAz3ufZHNkYQp1BjzH mlNi9C1Vw6V8tadrBTO514HsMCrRVb0s/q+GQZMCGh6E8FPK9hIekWOiADGORVs= =dv3x -----END PGP SIGNATURE----- --WeDu0lr7bteb/II5--