From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45685)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YDZV0-000197-9s
	for qemu-devel@nongnu.org; Tue, 20 Jan 2015 09:09:43 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YDZUx-00065v-4W
	for qemu-devel@nongnu.org; Tue, 20 Jan 2015 09:09:42 -0500
Received: from mx1.redhat.com ([209.132.183.28]:37852)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YDZUw-00065p-T8
	for qemu-devel@nongnu.org; Tue, 20 Jan 2015 09:09:39 -0500
Date: Tue, 20 Jan 2015 16:09:31 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20150120140931.GA29362@redhat.com>
References: <54BE6144.4020108@kamp.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <54BE6144.4020108@kamp.de>
Subject: Re: [Qemu-devel] Exposing different e1000 models through cmdline
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Lieven <pl@kamp.de>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>

On Tue, Jan 20, 2015 at 03:08:04PM +0100, Peter Lieven wrote:
> Hi,
> 
> I found that vmware emulates a 82545em per default and so some special crafted appliances only
> work with that card. I was wondering if the below is the right approach to make the
> models selectable via cmdline without changing the default:

No - please just use -device to create devices.

> diff --git a/hw/pci/pci.c b/hw/pci/pci.c
> index 371699c..632c4ba 100644
> --- a/hw/pci/pci.c
> +++ b/hw/pci/pci.c
> @@ -1578,6 +1578,9 @@ static const char * const pci_nic_models[] = {
>      "i82559er",
>      "rtl8139",
>      "e1000",
> +    "e1000-82540em",
> +    "e1000-82544gc",
> +    "e1000-82545em",
>      "pcnet",
>      "virtio",
>      NULL
> @@ -1590,6 +1593,9 @@ static const char * const pci_nic_names[] = {
>      "i82559er",
>      "rtl8139",
>      "e1000",
> +    "e1000-82540em",
> +    "e1000-82544gc",
> +    "e1000-82545em",
>      "pcnet",
>      "virtio-net-pci",
>      NULL
> 
> 
> Thanks,
> Peter