From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49831) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDZlM-0001uy-TQ for qemu-devel@nongnu.org; Tue, 20 Jan 2015 09:26:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YDZlH-0003UA-7x for qemu-devel@nongnu.org; Tue, 20 Jan 2015 09:26:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47899) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDZlH-0003Tr-0G for qemu-devel@nongnu.org; Tue, 20 Jan 2015 09:26:31 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0KEQTKI013245 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 20 Jan 2015 09:26:30 -0500 Date: Tue, 20 Jan 2015 14:26:28 +0000 From: Stefan Hajnoczi Message-ID: <20150120142628.GQ17631@stefanha-thinkpad.redhat.com> References: <1421372322-17829-1-git-send-email-famz@redhat.com> <20150116132319.GA32469@stefanha-thinkpad.redhat.com> <54B95DC9.8030606@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="XG0jWBK27HhJN4nS" Content-Disposition: inline In-Reply-To: <54B95DC9.8030606@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2] qemu-iotests: Fix supported_oses check List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: Kevin Wolf , Fam Zheng , qemu-devel@nongnu.org --XG0jWBK27HhJN4nS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 16, 2015 at 01:51:53PM -0500, John Snow wrote: >=20 >=20 > On 01/16/2015 08:23 AM, Stefan Hajnoczi wrote: > >On Fri, Jan 16, 2015 at 09:38:42AM +0800, Fam Zheng wrote: > >>There is a bug in the recently added sys.platform test, and we no longer > >>run python tests, because "linux2" is the value to compare here. So do a > >>prefix match. According to python doc [1], the way to use sys.platform > >>is "unless you want to test for a specific system version, it is > >>therefore recommended to use the following idiom": > >> > >>if sys.platform.startswith('freebsd'): > >> # FreeBSD-specific code here... > >>elif sys.platform.startswith('linux'): > >> # Linux-specific code here... > >> > >>[1]: https://docs.python.org/2.7/library/sys.html#sys.platform > >> > >>Signed-off-by: Fam Zheng > >> > >>--- > >>v2: Don't use any(). > >> Explain why prefix match is fine. > >> (Thanks, Stefan) > >>--- > >> tests/qemu-iotests/iotests.py | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > > > >Thanks, applied to my block tree: > >https://github.com/stefanha/qemu/commits/block > > > >Stefan > > >=20 > Thanks for this! >=20 > fake_internet_karma++ It's called Reddit^H^H^H^H^H^HQEMU Gold! Stefan --XG0jWBK27HhJN4nS Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUvmWUAAoJEJykq7OBq3PIsQEIAJHdqmlwBcHxw8tOuG0wEuIq r88excGT361OjmrDJbceSPHqdnbU0NLE5uKwpFOpb1B8m7+2vPJFuXmaJnkxpVeq 3fgP3Y74GSZdM0t+ZNJRWT7kuALYH9IFlynEtBtTFfBRpBJcn/GOs2BWPhzVMW/U NZDT2eCYheW1ESIU+Y5lnfVbgpPRFd2Xr4BQpEeQOQk8+fDxOWO9cjodgvqvZamD lvb+gi/yGvWbOOmY0W1bvVsexVNfmy1xGERvher6RHlV4cJKpyTPZpGVOJbVae8H ovrH+ju3LwattyV7o4+6T7PL2Gqv7auUJgYcvfWjP+8CCXu1YjaQRJNVYye3wPU= =NzrG -----END PGP SIGNATURE----- --XG0jWBK27HhJN4nS--