From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47096) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDbMD-0001Dj-5u for qemu-devel@nongnu.org; Tue, 20 Jan 2015 11:08:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YDbM7-0005FM-JV for qemu-devel@nongnu.org; Tue, 20 Jan 2015 11:08:45 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40907) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDbM7-0005F5-5D for qemu-devel@nongnu.org; Tue, 20 Jan 2015 11:08:39 -0500 Date: Tue, 20 Jan 2015 17:08:07 +0100 From: Christophe Fergeau Message-ID: <20150120160807.GM8982@edamame.cdg.redhat.com> References: <1508539.cfTQauU1Ry@javinlg> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7fwXp2o0gOrkU5lS" Content-Disposition: inline In-Reply-To: <1508539.cfTQauU1Ry@javinlg> Subject: Re: [Qemu-devel] [Spice-devel] [PATCH] [RFC] LZ4 compression option for SPICE List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Javier Celaya Cc: spice-devel , flex.dev@nologin.es, qemu-devel@nongnu.org, Anthony Liguori --7fwXp2o0gOrkU5lS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hey, On Thu, Jan 08, 2015 at 11:50:13AM +0100, Javier Celaya wrote: > Hello >=20 > Recently, SPICE included the lz4 compression algorithm. This patch adds > a command line option to select it. However, SPICE_IMAGE_COMPRESS_LZ4 did= not=20 > exist before the commit that added this compression algorithm, so it shou= ld be=20 > guarded with conditional compilation. How do you think this should be don= e?=20 > Wait for the next stable version of spice-server and check for=20 > SPICE_SERVER_VERSION? Or add a specific flag? Version check seems good, we probably can raise spice-server version in git preemptively so that you can have a working version check now. Given that lz4 support is optional, spice_server_set_image_compression should probably error out if we try to set lz4 but it's not supported. Christophe --7fwXp2o0gOrkU5lS Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCAAGBQJUvn1nAAoJEKnYwhQprGyCGmgP/3GQ/CJLhbPa7rGn2R9hRvMb VnEr5+8lksrCiY4j5z2EUNhHfjyDmNAZZE+EVeIvwTGfYhetbEziDhMx8wLph52q n2QCbw0KCbV0tXduIQmri+IMBq4ddT1vwsJ8kegF2AsPtQWGhAJg7iTJ4P1ESesL vuXVFnU1KPpkKgZfUqKn8S6uDMUBkjq3iSSX0/d9rxa7Le761GA3MW3a8WMlWaLU +uc+GLzSgN4TImQceUW8V53e02VE8B9zn6G/AhfBJk9QlpeceFBH6X/j5SXry7LG Z/FpwibZJrKGNDDjq5COW+tP+xfMHPT2p05nDJjjtVPM0zFHJ78n0F8Z7gZJ5llc fsdNDuVNq5s1X3eEHZ+ObLp2J4Oby+w/HpgAzRd1G5dxOO8GCmQ6RPKXLoYr0R27 RNY9ChMfZ2u8z8dqYS9pSC5PgvzMh8NSnFS9U0WO0zB3OrN0BBTJZ/tiP+1XsOoy 4dhwYIyxzoYlmQgaRVDwOAj+WgqFHmqg/zzBpISV8TviPTpeT4yEXFJbEiPgUgaq GCI4oyTAK5dl3MF79U+qbOZMxQseMzrZvinUg7ZczNFIE7brhcQnCyIz++oiQOOp hohOYtcGBrO6pfbqB0mSvz2nLsUpuJ27Tg5tJIjCHdU/radOBeLScEboIzZu5V8A UAQnUIsG+2iL5/dDKED7 =vIkW -----END PGP SIGNATURE----- --7fwXp2o0gOrkU5lS--