From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52011) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDbcn-0003SV-OA for qemu-devel@nongnu.org; Tue, 20 Jan 2015 11:25:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YDbck-0003Hx-Bt for qemu-devel@nongnu.org; Tue, 20 Jan 2015 11:25:53 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51720) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDbck-0003Hj-46 for qemu-devel@nongnu.org; Tue, 20 Jan 2015 11:25:50 -0500 Date: Tue, 20 Jan 2015 17:25:43 +0100 From: Igor Mammedov Message-ID: <20150120172543.4fc0b08f@nial.brq.redhat.com> In-Reply-To: References: <1421706621-23731-1-git-send-email-greg.bellows@linaro.org> <1421706621-23731-2-git-send-email-greg.bellows@linaro.org> <20150120162212.4e6f5277@nial.brq.redhat.com> <20150120165941.39c9a0f5@nial.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/5] target-arm: Add ARM CPU feature parsing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers , Greg Bellows , Eduardo Habkost , Christoffer Dall , Andreas =?UTF-8?B?RsOkcmJlcg==?= On Tue, 20 Jan 2015 16:08:09 +0000 Peter Maydell wrote: > On 20 January 2015 at 15:59, Igor Mammedov wrote: > > On Tue, 20 Jan 2015 15:34:23 +0000 > > Peter Maydell wrote: > > > >> On 20 January 2015 at 15:22, Igor Mammedov wrote: > >> > Please do not use legacy +-feature format and support only foo=val format. > >> > Other targets have it only for to being able support legacy setups > >> > which use +- format. > >> > >> I thought this was the standard format for CPU features. Do you > >> have an example of a CPU feature being set using foo=val format? > > Currently on x86 we can use either legacy +foo1,-foo2,foo3 and > > in addition to it we ca use canonized format for generic properties > > like, foo1=on,foo2=off,foo3=on > > > > We try to move out of legacy format, so that it would be possible > > to reuse generic property parsing infrastructure like with any > > device object. That would allow to use -device/device_add for CPUs. > > -device/-device_add for CPUs is pretty fraught in the general > case because there's no obvious place to plug them and have > them be wired up properly. That depends on CPU of-cause, but we are close to having device_add working with x86 CPUs. > You'd need to use -global for CPU > properties, which is a nightmare... mine thoughts on it were that '-cpu type,feat...' would eventually do conversion of features to global properties transparently for user using target specific cc->parse_features() callback. Which Greg could actually do here. We would happy to reuse it with x86 CPUs. > > Anyway, I'm not particularly attached to the exact command > line syntax we've used here -- I was just looking for "we have > a CPU property, and use the same syntax for specifying CPU > feature enable/disable that other CPUs do"... Then '-cpu arm_foo,featX=on/off' should do the job. > > -- PMM