From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57589) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDiul-0007g7-Iv for qemu-devel@nongnu.org; Tue, 20 Jan 2015 19:12:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YDiuh-0002pR-HA for qemu-devel@nongnu.org; Tue, 20 Jan 2015 19:12:55 -0500 Received: from ozlabs.org ([103.22.144.67]:46822) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDiuh-0002pB-5z for qemu-devel@nongnu.org; Tue, 20 Jan 2015 19:12:51 -0500 Date: Wed, 21 Jan 2015 10:56:40 +1100 From: David Gibson Message-ID: <20150120235640.GA27371@voom.fritz.box> References: <1421687077-9025-1-git-send-email-stefanha@redhat.com> <1421687077-9025-2-git-send-email-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="gKMricLos+KVdGMg" Content-Disposition: inline In-Reply-To: <1421687077-9025-2-git-send-email-stefanha@redhat.com> Subject: Re: [Qemu-devel] [PATCH 1/2] dataplane: move vring_more_avail() into vring.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org --gKMricLos+KVdGMg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 19, 2015 at 05:04:36PM +0000, Stefan Hajnoczi wrote: > vring_more_avail() was an inline function in vring.h. No external > callers use it so it's not necessary to export it. >=20 > Furthermore, we'll need virtio-access.h for endian-aware memory accesses > but that only works in per-target object files (obj-y) and not > build-once object files (common-obj-y) like the virtio-blk and > virtio-scsi devices. >=20 > Move vring_more_avail() into vring.c so that virtio devices like > virtio-blk and virtio-scsi can continue to use vring.h without being > built once per target. >=20 > Signed-off-by: Stefan Hajnoczi Looks sensible to me. Reviewed-by: David Gibson Tested-by: David Gibson --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --gKMricLos+KVdGMg Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUvus4AAoJEGw4ysog2bOSHSUP/0fFDv/JiUN/v+8CWkBur7NQ gvGDn37r6V+CDstl0RE56+JLer1ayk9TX9r/TU0m1+dIvi9lXKeD97YltDVFahdX 9G/sCpVHEq2qX2Tem6mJwdkBkffRevHS1b6WKXh53BdM0Mta6MMRvtCrhAjSIL9/ 9Bi5rQL7b0wqNxp1404j6zFPp7TyLDCuEekIjjpmPKcCelh10Bxf7KZ+/pVl13oC t/PIEOfsf2Oubdv9BcFYMPI7sfTyhMGhcDsOsxJHkL2gVeVf5T5QWzgdQzd5mkLJ WdvJj+NMPPWx9EmNE/pLloG4GW/kknNutBWbL+kDvhFgACTec7jHO7LRZx9/A0w1 QDnNFfJrVNa7aF1VW7HXy7vEcisjyVO3PkyajiuGF3jcoKd3ogrUIHlCGvx/JymF SOrqBSqDzDlXlwOAJ6F/Qla3YYlMg7TO4rTM5Du3drSf/yr74eHqZHXIbyMdnIAv sanaYUvYGeBXa4hzncy2Q5Xq3suBPD4VVXrlTGDGwKckDmn+yVN7ww40A580vzlN iUrXLLnaVy0IPgnTDQgxB9PYZqi5JL5PM8BZLt/lweYl8x3VNmxdEkzr/vEReycB ZJ7W9SFcCybiIF3tXi5OM+9kaWl/OBXuQlHfaf7l6crUny0lmllMVoWdWeTiIC+Z 9p1Ve8JP6ZxXDXJCxkrU =VMH8 -----END PGP SIGNATURE----- --gKMricLos+KVdGMg--