From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54105) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YE7Rq-0001qJ-1q for qemu-devel@nongnu.org; Wed, 21 Jan 2015 21:24:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YE7Rk-0007Nl-HD for qemu-devel@nongnu.org; Wed, 21 Jan 2015 21:24:41 -0500 Received: from ozlabs.org ([103.22.144.67]:45120) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YE7Rk-0007Mq-4s for qemu-devel@nongnu.org; Wed, 21 Jan 2015 21:24:36 -0500 Date: Thu, 22 Jan 2015 12:24:08 +1100 From: David Gibson Message-ID: <20150122012408.GC27371@voom.fritz.box> References: <1418304322-7546-1-git-send-email-cornelia.huck@de.ibm.com> <1418304322-7546-3-git-send-email-cornelia.huck@de.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="tqI+Z3u+9OQ7kwn0" Content-Disposition: inline In-Reply-To: <1418304322-7546-3-git-send-email-cornelia.huck@de.ibm.com> Subject: Re: [Qemu-devel] [PATCH RFC v6 02/20] virtio: cull virtio_bus_set_vdev_features List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: thuth@linux.vnet.ibm.com, rusty@rustcorp.com.au, mst@redhat.com, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org --tqI+Z3u+9OQ7kwn0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 11, 2014 at 02:25:04PM +0100, Cornelia Huck wrote: > The only user of this function was virtio-ccw, and it should use > virtio_set_features() like everybody else: We need to make sure > that bad features are masked out properly, which this function did > not do. >=20 > Reviewed-by: Thomas Huth > Signed-off-by: Cornelia Huck Reviewed-by: David Gibson --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --tqI+Z3u+9OQ7kwn0 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUwFE4AAoJEGw4ysog2bOSC9wQAJCyBGFawyqCcREAiu86evo0 zjLXmxdJ4xA1pDwzu6rPuNLbtoZYU72v3DLUs1+9ygeW7rTn/Y+pmCDpuYGmxuaF kKYvzN3Qa8WWMg39urWcyu/7AU8C1InThYKBNE7Yb1DdwCxtERtz1GQH6NqhdR9j 2/UDh21Rp6YmiWfq+oZ5VDl/FmgbnKu8wKyggt9LPlpXYTH1ArjsRGHOpHChRqnY kqIzaI634kXok4PP4VQjzHdNrG9TT2blB/lcB/5figIXwrFeBqmbNBYgBidlKMqI 6mukFAjxSQ1iQj3IVRp4RfdSkIRQgdRffTh0z6dq5SXR0GkRX+sPEZliY6s0xe3U AqySuL27QRCvtm0wi6mfuSbNGiTJa9IJGjcvk5RMxii/jMy83QiGnNBmJV4DmKyq ZBDZbDhH2Ri6dKj59WluqsQRYHtlFRPoLvYnqbPKQZ9Ti2ML3lJu5qL2BENPEuXe RrtLyXDD6BF5gpzAiC3kDniE6TtUgFgUpt8zbxuqtAdSRGuvQk/dCzyiYOe4FCfV K7RP1A/xG2o9F94TYqzY0L/C79ki/kZkQP/pMG/J5nlkeaBcBM/2uLIrShzhKHXl L84K9OdduIjKpYPjG2PxgOwRTvFw/7Qu58U4XRoB3PNJbSBe1K37vtkTs+P0oUeM cY/CipvrOj1TlzKTgsTL =zvBL -----END PGP SIGNATURE----- --tqI+Z3u+9OQ7kwn0--