From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54108) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YE7Rq-0001qP-30 for qemu-devel@nongnu.org; Wed, 21 Jan 2015 21:24:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YE7Rk-0007Ns-IM for qemu-devel@nongnu.org; Wed, 21 Jan 2015 21:24:42 -0500 Received: from ozlabs.org ([103.22.144.67]:41893) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YE7Rk-0007Mn-7h for qemu-devel@nongnu.org; Wed, 21 Jan 2015 21:24:36 -0500 Date: Thu, 22 Jan 2015 12:25:47 +1100 From: David Gibson Message-ID: <20150122012547.GD27371@voom.fritz.box> References: <1418304322-7546-1-git-send-email-cornelia.huck@de.ibm.com> <1418304322-7546-4-git-send-email-cornelia.huck@de.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="NtwzykIc2mflq5ck" Content-Disposition: inline In-Reply-To: <1418304322-7546-4-git-send-email-cornelia.huck@de.ibm.com> Subject: Re: [Qemu-devel] [PATCH RFC v6 03/20] virtio: feature bit manipulation helpers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: thuth@linux.vnet.ibm.com, rusty@rustcorp.com.au, mst@redhat.com, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org --NtwzykIc2mflq5ck Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 11, 2014 at 02:25:05PM +0100, Cornelia Huck wrote: > Add virtio_{add,clear}_feature helper functions for manipulating a > feature bits variable. This has some benefits over open coding: > - add check that the bit is in a sane range > - make it obvious at a glance what is going on > - have a central point to change when we want to extend feature bits >=20 > Convert existing code manipulating features to use the new helpers. >=20 > Signed-off-by: Cornelia Huck Reviewed-by: David Gibson --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --NtwzykIc2mflq5ck Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUwFGbAAoJEGw4ysog2bOSmwoP/AgqhAG/evVDtyoOhl75yFZM UqERPUonXLJ/2dmfdi9hWlmMue3NwkBBww/5dqszl5rj6WrfCDI7vDpcRsAFs796 S1RmAFDk+i+Jy/TbwRkH8e8SS1Sue0U0qilJOXniTp8rVDcbSi9sKrwZhw985g0/ fWa1fJohNWYuPlgU5/KS2YswSMmpq1EodHn6rDxJyw83US/J/9dmWt42ipOtjn4d ARAjRuZFpEuTd7SwQM3mOs9zR6G35bqzAjYEIIVwA6CrFDBIaRuFhlkZtlWylJ0x 7CTqzY7Skg6Ms5eULoMI07Aeneu0JhOTnuwfqu4cxnzwO7+JKTr/gRstU90T5sUe jWFsPuEh91xt2/C0QHGWG866sIH3zNFgfwbso+2rvsYsGaUPCAVp/QSg++2yPw3a qBv9DOJmxLAEk4ZH3jx8Rl2hzEk+r5QeGsY+JhEYD/AsbTIt4mk1R3W4lJMvbdTu vwpmuH18pJU9k7hqwMBuyi7/07jnbpbuL/zUnaMhgnJ5sQSOkvk0MIahiQQzNPw+ gQ6HTG28DybgPYMcpJxh6QVdtjTpd7zzabs6aNL4rJpqlzjU+85aM0CluG8cLb5z neia8U1y4kaPx0R24ilD7zoOul7dCJFL3LmqqDl+GD1FguJzoW7YwfivHqbJrtce 61ZcwCklHd01HPoyjBd5 =TbBz -----END PGP SIGNATURE----- --NtwzykIc2mflq5ck--