From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53900) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEKjh-0006dS-8I for qemu-devel@nongnu.org; Thu, 22 Jan 2015 11:36:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YEKjd-00046A-00 for qemu-devel@nongnu.org; Thu, 22 Jan 2015 11:36:01 -0500 Received: from e06smtp16.uk.ibm.com ([195.75.94.112]:41115) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEKjc-0003uz-N1 for qemu-devel@nongnu.org; Thu, 22 Jan 2015 11:35:56 -0500 Received: from /spool/local by e06smtp16.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 22 Jan 2015 16:35:10 -0000 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 9A0ED17D8062 for ; Thu, 22 Jan 2015 16:31:23 +0000 (GMT) Received: from d06av03.portsmouth.uk.ibm.com (d06av03.portsmouth.uk.ibm.com [9.149.37.213]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t0MGVK0856230060 for ; Thu, 22 Jan 2015 16:31:20 GMT Received: from d06av03.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av03.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t0MGVI7d012424 for ; Thu, 22 Jan 2015 09:31:20 -0700 Date: Thu, 22 Jan 2015 17:31:17 +0100 From: Cornelia Huck Message-ID: <20150122173117.46f7ba32.cornelia.huck@de.ibm.com> In-Reply-To: <20150120111947.GM17631@stefanha-thinkpad.redhat.com> References: <1418304322-7546-1-git-send-email-cornelia.huck@de.ibm.com> <1418304322-7546-16-git-send-email-cornelia.huck@de.ibm.com> <20150120111947.GM17631@stefanha-thinkpad.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RFC v6 15/20] virtio-net: no writeable mac for virtio-1 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: thuth@linux.vnet.ibm.com, mst@redhat.com, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org On Tue, 20 Jan 2015 11:19:47 +0000 Stefan Hajnoczi wrote: > On Thu, Dec 11, 2014 at 02:25:17PM +0100, Cornelia Huck wrote: > > Devices operating as virtio 1.0 may not allow writes to the mac > > address in config space. > > > > Signed-off-by: Cornelia Huck > > --- > > hw/net/virtio-net.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c > > index d6d1b98..ebbea60 100644 > > --- a/hw/net/virtio-net.c > > +++ b/hw/net/virtio-net.c > > @@ -87,6 +87,7 @@ static void virtio_net_set_config(VirtIODevice *vdev, const uint8_t *config) > > memcpy(&netcfg, config, n->config_size); > > > > if (!virtio_has_feature(vdev, VIRTIO_NET_F_CTRL_MAC_ADDR) && > > I don't see VIRTIO_NET_F_CTRL_MAC_ADDR (23) in the VIRTIO 1.0 "5.1.3.1 > Legacy Interface: Feature bits" section. Should it be there just so > people don't try to reuse bit 23 in the future? But this isn't a legacy flag. Virtio-1 devices simply may not manipulate the mac address directly even if this feature has not been negotiated. > > The patch itself: > Reviewed-by: Stefan Hajnoczi