From: Kevin Wolf <kwolf@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/2] qcow2: Add two more unalignment checks
Date: Thu, 22 Jan 2015 19:04:45 +0100 [thread overview]
Message-ID: <20150122180445.GA3958@noname.redhat.com> (raw)
In-Reply-To: <1421700544-24635-1-git-send-email-mreitz@redhat.com>
Am 19.01.2015 um 21:49 hat Max Reitz geschrieben:
> With the series adding unalignment checks and the series reworking the
> zero cluster expansion code overlapping, the unalignment checks have not
> been implemented in the latter code.
>
> This series fixes it.
>
> There are other places which would require unalignment checks, like the
> offsets of L1 tables, especially for snapshots; but because it would be
> best to add these checks in the function which reads the snapshot table,
> this would make images with broken snapshots completely unusable, which
> is something I opted to avoid for now.
>
> Ideally, we need to make the qcow2 repair function repair such cases,
> but until that is done there is not much we can do about them.
Thanks, applied to the block branch.
Kevin
prev parent reply other threads:[~2015-01-22 18:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-19 20:49 [Qemu-devel] [PATCH 0/2] qcow2: Add two more unalignment checks Max Reitz
2015-01-19 20:49 ` [Qemu-devel] [PATCH 1/2] " Max Reitz
2015-01-19 20:49 ` [Qemu-devel] [PATCH 2/2] iotests: Add tests for more corruption cases Max Reitz
2015-01-19 21:04 ` [Qemu-devel] [PATCH 0/2] qcow2: Add two more unalignment checks Eric Blake
2015-01-19 21:09 ` Max Reitz
2015-01-20 10:09 ` Kevin Wolf
2015-01-20 13:49 ` Max Reitz
2015-01-20 14:00 ` Kevin Wolf
2015-01-20 14:01 ` Max Reitz
2015-01-22 18:04 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150122180445.GA3958@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).