From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48214)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1YEM7j-00065b-FX
	for qemu-devel@nongnu.org; Thu, 22 Jan 2015 13:05:00 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1YEM7d-0002Nh-LF
	for qemu-devel@nongnu.org; Thu, 22 Jan 2015 13:04:55 -0500
Received: from mx1.redhat.com ([209.132.183.28]:38821)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1YEM7d-0002NT-Dl
	for qemu-devel@nongnu.org; Thu, 22 Jan 2015 13:04:49 -0500
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0MI4lJN009198
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Thu, 22 Jan 2015 13:04:47 -0500
Date: Thu, 22 Jan 2015 19:04:45 +0100
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20150122180445.GA3958@noname.redhat.com>
References: <1421700544-24635-1-git-send-email-mreitz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1421700544-24635-1-git-send-email-mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/2] qcow2: Add two more unalignment checks
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

Am 19.01.2015 um 21:49 hat Max Reitz geschrieben:
> With the series adding unalignment checks and the series reworking the
> zero cluster expansion code overlapping, the unalignment checks have not
> been implemented in the latter code.
> 
> This series fixes it.
> 
> There are other places which would require unalignment checks, like the
> offsets of L1 tables, especially for snapshots; but because it would be
> best to add these checks in the function which reads the snapshot table,
> this would make images with broken snapshots completely unusable, which
> is something I opted to avoid for now.
> 
> Ideally, we need to make the qcow2 repair function repair such cases,
> but until that is done there is not much we can do about them.

Thanks, applied to the block branch.

Kevin