From: "Michael S. Tsirkin" <mst@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/3] virtio-pci: 1.0 tweaks
Date: Fri, 23 Jan 2015 11:21:20 +0200 [thread overview]
Message-ID: <20150123092120.GJ26711@redhat.com> (raw)
In-Reply-To: <1422001889.13166.10.camel@nilsson.home.kraxel.org>
On Fri, Jan 23, 2015 at 09:31:29AM +0100, Gerd Hoffmann wrote:
> Hi,
>
> > Figured notification seems to not be adapted to virtio 1.0 yet: Apply
> > this patchset, boot with -device virtio-net-pci,disable-legacy=on, watch
> > qemu blow up in virtio_pci_set_host_notifier_internal, because it uses
> > uninitialited proxy->bar without checking. Looked closer, seems the
> > virtio 1.0 notification memory region isn't wired up yet ...
>
> Oh, looking at the stacktrace again I see vhost in there, which IIRC
> isn't ready yet. Turned off vhost -- things are working nicely.
>
> cheers,
> Gerd
yes - merely need to propage the new feature bit
in both directions.
prev parent reply other threads:[~2015-01-23 9:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-22 8:57 [Qemu-devel] [PATCH 0/3] virtio-pci: 1.0 tweaks Gerd Hoffmann
2015-01-22 8:57 ` [Qemu-devel] [PATCH 1/3] virtio-pci: add flags to enable/disable legacy/modern Gerd Hoffmann
2015-01-22 8:57 ` [Qemu-devel] [PATCH 2/3] virtio-pci: use bar0 for non-transitional devices Gerd Hoffmann
2015-01-22 8:57 ` [Qemu-devel] [PATCH 3/3] virtio-pci: make QEMU_VIRTIO_PCI_QUEUE_MEM_MULT smaller Gerd Hoffmann
2015-01-23 8:31 ` [Qemu-devel] [PATCH 0/3] virtio-pci: 1.0 tweaks Gerd Hoffmann
2015-01-23 9:21 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150123092120.GJ26711@redhat.com \
--to=mst@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).