From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57652)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YEaQi-0001TA-5O
	for qemu-devel@nongnu.org; Fri, 23 Jan 2015 04:21:28 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YEaQe-0003sQ-MS
	for qemu-devel@nongnu.org; Fri, 23 Jan 2015 04:21:28 -0500
Received: from mx1.redhat.com ([209.132.183.28]:56523)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YEaQe-0003sL-Eg
	for qemu-devel@nongnu.org; Fri, 23 Jan 2015 04:21:24 -0500
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0N9LNMp023005
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Fri, 23 Jan 2015 04:21:23 -0500
Date: Fri, 23 Jan 2015 11:21:20 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20150123092120.GJ26711@redhat.com>
References: <1421917056-6560-1-git-send-email-kraxel@redhat.com>
	<1422001889.13166.10.camel@nilsson.home.kraxel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1422001889.13166.10.camel@nilsson.home.kraxel.org>
Subject: Re: [Qemu-devel] [PATCH 0/3] virtio-pci: 1.0 tweaks
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

On Fri, Jan 23, 2015 at 09:31:29AM +0100, Gerd Hoffmann wrote:
>   Hi,
> 
> > Figured notification seems to not be adapted to virtio 1.0 yet:  Apply
> > this patchset, boot with -device virtio-net-pci,disable-legacy=on, watch
> > qemu blow up in virtio_pci_set_host_notifier_internal, because it uses
> > uninitialited proxy->bar without checking.  Looked closer, seems the
> > virtio 1.0 notification memory region isn't wired up yet ...
> 
> Oh, looking at the stacktrace again I see vhost in there, which IIRC
> isn't ready yet.  Turned off vhost -- things are working nicely.
> 
> cheers,
>   Gerd


yes - merely need to propage the new feature bit
in both directions.