From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44149) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEbby-0004kR-Am for qemu-devel@nongnu.org; Fri, 23 Jan 2015 05:37:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YEbbo-0004US-RJ for qemu-devel@nongnu.org; Fri, 23 Jan 2015 05:37:10 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60521) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEbbo-0004UF-Bc for qemu-devel@nongnu.org; Fri, 23 Jan 2015 05:37:00 -0500 Date: Fri, 23 Jan 2015 11:36:50 +0100 From: Igor Mammedov Message-ID: <20150123113650.634d6a33@nial.brq.redhat.com> In-Reply-To: <20150123080254.GC26711@redhat.com> References: <1421938231-25698-1-git-send-email-imammedo@redhat.com> <1421938231-25698-3-git-send-email-imammedo@redhat.com> <20150123080254.GC26711@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 02/47] acpi: add acpi_scope() term List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: pbonzini@redhat.com, drjones@redhat.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, marcel.a@redhat.com On Fri, 23 Jan 2015 10:02:54 +0200 "Michael S. Tsirkin" wrote: > On Thu, Jan 22, 2015 at 02:49:46PM +0000, Igor Mammedov wrote: > > Signed-off-by: Igor Mammedov > > --- > > hw/acpi/acpi-build-utils.c | 18 ++++++++++++++++++ > > include/hw/acpi/acpi-build-utils.h | 4 ++++ > > 2 files changed, 22 insertions(+) > > > > diff --git a/hw/acpi/acpi-build-utils.c b/hw/acpi/acpi-build-utils.c > > index 547ecaa..e13d748 100644 > > --- a/hw/acpi/acpi-build-utils.c > > +++ b/hw/acpi/acpi-build-utils.c > > @@ -306,3 +306,21 @@ void aml_append(AcpiAml *parent_ctx, AcpiAml child) > > build_append_array(parent_ctx->buf, child.buf); > > build_free_array(child.buf); > > } > > + > > +static AcpiAml aml_allocate_internal(uint8_t op, AcpiBlockFlags flags) > > +{ > > + AcpiAml var = { .op = op, .block_flags = flags }; > > + var.buf = build_alloc_array(); > > + return var; > > +} > > + > > Is there also allocate_external? If not - static is enough to > know it's not an API function. There isn't, I'll fix it up. > > > +/* ACPI 5.0: 20.2.5.1 Namespace Modifier Objects Encoding: DefScope */ > > +AcpiAml GCC_FMT_ATTR(1, 2) acpi_scope(const char *name_format, ...) > > +{ > > + va_list ap; > > + AcpiAml var = aml_allocate_internal(0x10 /* ScopeOp */, PACKAGE); > > + va_start(ap, name_format); > > + build_append_namestringv(var.buf, name_format, ap); > > + va_end(ap); > > + return var; > > +} > > diff --git a/include/hw/acpi/acpi-build-utils.h b/include/hw/acpi/acpi-build-utils.h > > index 64e7ec3..bbb786b 100644 > > --- a/include/hw/acpi/acpi-build-utils.h > > +++ b/include/hw/acpi/acpi-build-utils.h > > @@ -21,6 +21,10 @@ typedef struct AcpiAml { > > > > void aml_append(AcpiAml *parent_ctx, AcpiAml child); > > > > +/* Block ASL object primitives */ > > +AcpiAml GCC_FMT_ATTR(1, 2) acpi_scope(const char *name_format, ...); > > + > > +/* other helpers */ > > GArray *build_alloc_array(void); > > void build_free_array(GArray *array); > > void build_prepend_byte(GArray *array, uint8_t val); > > -- > > 1.8.3.1 >