From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Liang Li <liang.z.li@intel.com>
Cc: quintela@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com,
lcapitulino@redhat.com, yang.z.zhang@intel.com
Subject: Re: [Qemu-devel] [PATCH v3 0/13] migration: Add a new feature to do live migration
Date: Fri, 23 Jan 2015 13:10:48 +0000 [thread overview]
Message-ID: <20150123131048.GA8961@work-vm> (raw)
In-Reply-To: <1418347746-15829-1-git-send-email-liang.z.li@intel.com>
* Liang Li (liang.z.li@intel.com) wrote:
> This feature can help to reduce the data transferred about 60%, and the
> migration time can also be reduced about 70%.
>
> Summary of changed from v2->v3
>
> -Splited the patch to 13 parts instead of 2
> -Rewrote the core code to do compression and decompression
> -Updated the document
> -Added a common command interface to set and query parameters
> -Added some comments
Hi,
Apologies for taking so long; generally this is a lot nicer.
I'll reply to each patch individually, but two more general questions:
a) Shouldn't compressBound be used somewhere to get the worst case compressed size?
b) I think adding some trace points would be useful; it would make it easier to
spot when you were waiting for threads etc.
Dave
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2015-01-23 13:11 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-12 1:28 [Qemu-devel] [PATCH v3 0/13] migration: Add a new feature to do live migration Liang Li
2014-12-12 1:28 ` [Qemu-devel] [v3 01/13] docs: Add a doc about multiple thread compression Liang Li
2015-01-23 13:17 ` Dr. David Alan Gilbert
2015-01-23 15:24 ` Eric Blake
2014-12-12 1:28 ` [Qemu-devel] [v3 02/13] migration: Add the framework of multi-thread compression Liang Li
2015-01-23 13:23 ` Dr. David Alan Gilbert
2015-01-23 16:09 ` Eric Blake
2014-12-12 1:28 ` [Qemu-devel] [v3 03/13] migration: Add the framework of muti-thread decompression Liang Li
2015-01-23 13:26 ` Dr. David Alan Gilbert
2015-01-23 16:22 ` Eric Blake
2014-12-12 1:28 ` [Qemu-devel] [v3 04/13] qemu-file: Add tow function will be used in migration Liang Li
2015-01-23 13:31 ` Dr. David Alan Gilbert
2015-01-24 13:42 ` Li, Liang Z
2014-12-12 1:28 ` [Qemu-devel] [v3 05/13] arch_init: alloc and free data struct in multi-thread compression Liang Li
2015-01-23 13:35 ` Dr. David Alan Gilbert
2015-01-24 13:46 ` Li, Liang Z
2014-12-12 1:28 ` [Qemu-devel] [v3 06/13] arch_init: Add data struct used by decompression Liang Li
2014-12-12 1:29 ` [Qemu-devel] [v3 07/13] migraion: Rewrite the function ram_save_page() Liang Li
2015-01-23 13:38 ` Dr. David Alan Gilbert
2014-12-12 1:29 ` [Qemu-devel] [v3 08/13] migration: Add the core code of multi-thread compresion Liang Li
2015-01-23 13:39 ` Dr. David Alan Gilbert
2015-01-24 13:51 ` Li, Liang Z
2014-12-12 1:29 ` [Qemu-devel] [v3 09/13] migration: Make compression co-work with xbzrle Liang Li
2015-01-23 13:40 ` Dr. David Alan Gilbert
2014-12-12 1:29 ` [Qemu-devel] [v3 10/13] migration: Add the core code of multi-thread decompression Liang Li
2015-01-23 13:42 ` Dr. David Alan Gilbert
2014-12-12 1:29 ` [Qemu-devel] [v3 11/13] migration: Add interface to control compression Liang Li
2015-01-23 13:44 ` Dr. David Alan Gilbert
2015-01-23 15:26 ` Eric Blake
2014-12-12 1:29 ` [Qemu-devel] [v3 12/13] migration: Add command to set migration parameter Liang Li
2015-01-23 13:48 ` Dr. David Alan Gilbert
2015-01-23 15:42 ` Eric Blake
2015-01-23 15:59 ` Dr. David Alan Gilbert
2015-01-23 16:06 ` Eric Blake
2015-01-24 14:14 ` Li, Liang Z
2015-01-26 9:22 ` Dr. David Alan Gilbert
2015-01-23 15:39 ` Eric Blake
2014-12-12 1:29 ` [Qemu-devel] [v3 13/13] migration: Add command to query " Liang Li
2015-01-23 13:49 ` Dr. David Alan Gilbert
2015-01-23 15:47 ` Eric Blake
2014-12-24 5:08 ` [Qemu-devel] [PATCH v3 0/13] migration: Add a new feature to do live migration Li, Liang Z
2015-01-07 3:12 ` Li, Liang Z
2015-01-23 13:10 ` Dr. David Alan Gilbert [this message]
2015-01-24 13:25 ` Li, Liang Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150123131048.GA8961@work-vm \
--to=dgilbert@redhat.com \
--cc=armbru@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=liang.z.li@intel.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).