From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45859)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1YEe0p-0007ld-Je
	for qemu-devel@nongnu.org; Fri, 23 Jan 2015 08:11:00 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1YEe0l-0003sV-Ka
	for qemu-devel@nongnu.org; Fri, 23 Jan 2015 08:10:59 -0500
Received: from mx1.redhat.com ([209.132.183.28]:41940)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1YEe0l-0003s9-D7
	for qemu-devel@nongnu.org; Fri, 23 Jan 2015 08:10:55 -0500
Date: Fri, 23 Jan 2015 13:10:48 +0000
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Message-ID: <20150123131048.GA8961@work-vm>
References: <1418347746-15829-1-git-send-email-liang.z.li@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1418347746-15829-1-git-send-email-liang.z.li@intel.com>
Subject: Re: [Qemu-devel] [PATCH v3 0/13] migration: Add a new feature to do
	live migration
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Liang Li <liang.z.li@intel.com>
Cc: quintela@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, lcapitulino@redhat.com, yang.z.zhang@intel.com

* Liang Li (liang.z.li@intel.com) wrote:
> This feature can help to reduce the data transferred about 60%, and the
> migration time can also be reduced about 70%.
> 
>     Summary of changed from v2->v3
>     
>     -Splited the patch to 13 parts instead of 2
>     -Rewrote the core code to do compression and decompression 
>     -Updated the document
>     -Added a common command interface to set and query parameters
>     -Added some comments

Hi,
  Apologies for taking so long; generally this is a lot nicer.
I'll reply to each patch individually, but two more general questions:
   a) Shouldn't compressBound be used somewhere to get the worst case compressed size?
   b) I think adding some trace points would be useful; it would make it easier to
      spot when you were waiting for threads etc.

Dave

--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK