From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52105)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1YEePW-0002sT-S7
	for qemu-devel@nongnu.org; Fri, 23 Jan 2015 08:36:31 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1YEePV-0004bh-NE
	for qemu-devel@nongnu.org; Fri, 23 Jan 2015 08:36:30 -0500
Received: from mx1.redhat.com ([209.132.183.28]:39674)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1YEePV-0004bV-Gd
	for qemu-devel@nongnu.org; Fri, 23 Jan 2015 08:36:29 -0500
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0NDaSq6006863
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Fri, 23 Jan 2015 08:36:29 -0500
Date: Fri, 23 Jan 2015 14:36:24 +0100
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20150123133624.GA5231@noname.redhat.com>
References: <cover.1421931293.git.jcody@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cover.1421931293.git.jcody@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 0/6] Update filename string sizes in
	block layer
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jeff Cody <jcody@redhat.com>
Cc: jsnow@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com

Am 22.01.2015 um 14:03 hat Jeff Cody geschrieben:
> The block layer uses a mixture of 'PATH_MAX' and '1024' string sizes
> for filenames (and backing filenames).
> 
> This series consolidates all that usage to 'PATH_MAX'.  Since most platforms
> (especially the most common platforms for QEMU) have a PATH_MAX larger than
> 1024 bytes, this series also changes stack allocations of PATH_MAX to be
> dynamically allocated.
> 
> Note: checkpatch.pl complains about an extra space in a printf in
>       patches 1 & 2.  The lines complained about are in the diff context and
>       not the actual changes, so I did not fix them up to satisfy checkpatch.
> 
> Changes from v3:
>     - simplified extent_path handling in vmdk_parse_extents() (Thanks Stefan)
>     - moved declaration of backing_filename2 to inside if
>       statement in bdrv_query_image_info() (Thanks Stefan)
>     - removed zombie variable in bdrv_commit (Thanks Stefan)
>     - fixed typo in commit message (Thanks Stefan)
> 
> Changes from v2:
> 
>     - Change stack allocations to dybnamic (Thanks Kevin)
>     - Update qcow/qcow2 ti perform safety checks for platforms that
>       have a PATH_MAX < 1024 (thanks John, Kevin).

Thanks, applied to the block branch.

Kevin