From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54553) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEeXA-0003UJ-Gt for qemu-devel@nongnu.org; Fri, 23 Jan 2015 08:44:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YEeX4-00086P-MU for qemu-devel@nongnu.org; Fri, 23 Jan 2015 08:44:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59411) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEeX4-00086K-Dl for qemu-devel@nongnu.org; Fri, 23 Jan 2015 08:44:18 -0500 Date: Fri, 23 Jan 2015 13:44:12 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20150123134412.GK2370@work-vm> References: <1418347746-15829-1-git-send-email-liang.z.li@intel.com> <1418347746-15829-12-git-send-email-liang.z.li@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1418347746-15829-12-git-send-email-liang.z.li@intel.com> Subject: Re: [Qemu-devel] [v3 11/13] migration: Add interface to control compression List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Liang Li Cc: quintela@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, lcapitulino@redhat.com, yang.z.zhang@intel.com * Liang Li (liang.z.li@intel.com) wrote: > The multiple compression threads can be turned on/off through > qmp and hmp interface when doing live migration. > > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang > --- > migration.c | 7 +++++-- > qapi-schema.json | 6 +++++- > 2 files changed, 10 insertions(+), 3 deletions(-) > Reviewed-by: Dr. David Alan Gilbert > diff --git a/migration.c b/migration.c > index 082ddb7..9d1613d 100644 > --- a/migration.c > +++ b/migration.c > @@ -576,8 +576,11 @@ bool migrate_zero_blocks(void) > > bool migrate_use_compression(void) > { > - /* Disable compression before the series of patches are applied */ > - return false; > + MigrationState *s; > + > + s = migrate_get_current(); > + > + return s->enabled_capabilities[MIGRATION_CAPABILITY_COMPRESS]; > } > > int migrate_compress_level(void) > diff --git a/qapi-schema.json b/qapi-schema.json > index 9ffdcf8..d371af3 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -491,13 +491,17 @@ > # to enable the capability on the source VM. The feature is disabled by > # default. (since 1.6) > # > +# @compress: Using the multiple compression threads to accelerate live migration. > +# This feature can help to reduce the migration traffic, by sending > +# compressed pages. The feature is disabled by default. (since 2.3) > +# > # @auto-converge: If enabled, QEMU will automatically throttle down the guest > # to speed up convergence of RAM migration. (since 1.6) > # > # Since: 1.2 > ## > { 'enum': 'MigrationCapability', > - 'data': ['xbzrle', 'rdma-pin-all', 'auto-converge', 'zero-blocks'] } > + 'data': ['xbzrle', 'rdma-pin-all', 'auto-converge', 'zero-blocks', 'compress'] } > > ## > # @MigrationCapabilityStatus > -- > 1.8.3.1 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK